FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v18.x backport] deps: update icu to 74.2 by targos · Pull Request #51973 · nodejs/node · GitHub

/ node Public

[v18.x backport] deps: update icu to 74.2 - #51973

Closed
targos wants to merge 5 commits into
nodejs:v18.x-stagingfrom
targos:update-icu-v18.x
ConversationCommits (5)ChecksFiles changed
Closed

[v18.x backport] deps: update icu to 74.2#51973
targos wants to merge 5 commits into
nodejs:v18.x-stagingfrom
targos:update-icu-v18.x

Conversation

targos commented Mar 5, 2024

Copy link
Copy Markdown
Member
  • deps: update icu to 74.1
  • deps: update timezone to 2023d
  • tools: fix update-icu.sh
  • deps: update icu to 74.2
  • deps: update timezone to 2024a

Refs: #51933

nodejs-github-bot and others added 5 commits March 5, 2024 15:53
deps: update icu to 74.1
7cca463 
PR-URL: nodejs#50515
Reviewed-By: Steven R Loomis <srl295@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
deps: update timezone to 2023d
ab1114f 
PR-URL: nodejs#51461
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
tools: fix update-icu.sh
22980b8 
The name of the sources MD5 file has changed.

Refs: https://github.com/unicode-org/icu/releases/tag/release-74-2
PR-URL: nodejs#51723
Refs: nodejs#51721
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Steven R Loomis <srl295@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
deps: update icu to 74.2
3889bde 
Refs: https://github.com/unicode-org/icu/releases/tag/release-74-2
PR-URL: nodejs#51723
Refs: nodejs#51721
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Steven R Loomis <srl295@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
deps: update timezone to 2024a
a92d454 
PR-URL: nodejs#51723
Refs: https://github.com/unicode-org/icu/releases/tag/release-74-2
Refs: nodejs#51721
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Steven R Loomis <srl295@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

nodejs-github-bot commented Mar 5, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. v18.x labels Mar 5, 2024
targos mentioned this pull request Mar 5, 2024
Closed
targos added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 5, 2024
github-actions Bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 5, 2024

github-actions Bot commented Mar 5, 2024

Copy link
Copy Markdown
Contributor
Failed to start CI
/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/undici/lib/web/fetch/response.js:507
  ReadableStream
  ^

ReferenceError: ReadableStream is not defined

at Object. (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/undici/lib/web/fetch/response.js:507:3)

at Module._compile (node:internal/modules/cjs/loader:1198:14)

at Object.Module._extensions..js (node:internal/modules/cjs/loader:1252:10)

at Module.load (node:internal/modules/cjs/loader:1076:32)

at Function.Module._load (node:internal/modules/cjs/loader:911:12)

at Module.require (node:internal/modules/cjs/loader:1100:19)

at require (node:internal/modules/cjs/helpers:119:18)

at Object. (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/undici/lib/web/fetch/index.js:11:5)

at Module._compile (node:internal/modules/cjs/loader:1198:14)

at Object.Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
https://github.com/nodejs/node/actions/runs/8158770866

richardlau added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Mar 5, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 5, 2024

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view
richardlau linked an issue Mar 10, 2024 that may be closed by this pull request
Update node 18 to use ICU4C 74 #51556
Closed

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view
richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2024

nodejs-github-bot commented Mar 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57767/

richardlau pushed a commit that referenced this pull request Mar 18, 2024
deps: update icu to 74.1
2a2bf57 
PR-URL: #50515
Backport-PR-URL: #51973
Reviewed-By: Steven R Loomis <srl295@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Refs: #51933
richardlau pushed a commit that referenced this pull request Mar 18, 2024
deps: update timezone to 2023d
90c73d2 
PR-URL: #51461
Backport-PR-URL: #51973
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Refs: #51933
richardlau pushed a commit that referenced this pull request Mar 18, 2024
tools: fix update-icu.sh
3184bef 
The name of the sources MD5 file has changed.

Refs: https://github.com/unicode-org/icu/releases/tag/release-74-2
PR-URL: #51723
Backport-PR-URL: #51973
Refs: #51721
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Steven R Loomis <srl295@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Refs: #51933
richardlau pushed a commit that referenced this pull request Mar 18, 2024
deps: update icu to 74.2
f9b229e 
Refs: https://github.com/unicode-org/icu/releases/tag/release-74-2
PR-URL: #51723
Backport-PR-URL: #51973
Refs: #51721
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Steven R Loomis <srl295@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Refs: #51933
richardlau pushed a commit that referenced this pull request Mar 18, 2024
deps: update timezone to 2024a
68fd751 
PR-URL: #51723
Backport-PR-URL: #51973
Refs: https://github.com/unicode-org/icu/releases/tag/release-74-2
Refs: #51721
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Steven R Loomis <srl295@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Refs: #51933

richardlau commented Mar 18, 2024

Copy link
Copy Markdown
Member

Landed in fe66e9d...68fd751.

richardlau closed this Mar 18, 2024
targos deleted the update-icu-v18.x branch March 18, 2024 13:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
richardlau richardlau approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update node 18 to use ICU4C 74

4 participants

Back | FazBrowse Home | New Git URL