[v20.x] backport libuv wtf-8 decoding fix - #51976
Closed
richardlau wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Original commit message:
fs: fix WTF-8 decoding issue (nodejs#4092)
We forgot to mask off the high bits from the first byte, so we ended up
always failing the subsequent range check.
Refs: libuv/libuv#2970
Fixes: nodejs#48673
PR-URL: nodejs#51800 Fixes: nodejs#51789 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
RafaelGSS
approved these changes
Mar 5, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Mar 5, 2024
marco-ippolito
approved these changes
Mar 5, 2024
santigimeno
approved these changes
Mar 5, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
StefanStojanovic
approved these changes
Mar 9, 2024
UlisesGascon
approved these changes
Mar 10, 2024
UlisesGascon
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
mertcanaltin
approved these changes
Mar 14, 2024
mertcanaltin
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm 🚀
Sorry, something went wrong.
richardlau
added a commit
that referenced
this pull request
Mar 15, 2024
Original commit message:
fs: fix WTF-8 decoding issue (#4092)
We forgot to mask off the high bits from the first byte, so we ended up
always failing the subsequent range check.
Refs: libuv/libuv#2970
Fixes: #48673
PR-URL: #51976
Refs: #48673
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Copy link
Copy Markdown
Member
Author
|
FYI I'm aiming to do a Node.js 20 release around 26 March 2024 which will include this. |
Sorry, something went wrong.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports libuv/libuv@d09441c to Node.js 20 to fix a long standing regression in the way filenames are handled on Windows. On Node.js 21 this was fixed by the update to libuv 1.47.0, but that version cannot be backported to Node.js 20 because libuv have dropped support for macOS <11 and we target macOS 10.15 for Node.js 20.
Refs: #48673