meta: pass Codecov upload token to codecov action - #51982
Merged
nodejs-github-bot merged 1 commit intoMar 8, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I pushed the branch to the upstream to verify it works. Here are examples of previous upload failures:
|
Sorry, something went wrong.
This is required since version 4 of the action (except for pull requests opened from forks). Refs: https://github.com/codecov/codecov-action/blob/e7748388508dfb57a188b1593a92c9ca8d865365/README.md#v4-release
Copy link
Copy Markdown
Member
Author
|
FYI @nodejs/tsc: I created a global upload token for the nodejs org on https://app.codecov.io/account/gh/nodejs/org-upload-token and set it as an org secret on https://github.com/organizations/nodejs/settings/secrets/actions. You can allow other repositories to access the secret by editing it. |
Sorry, something went wrong.
MoLow
approved these changes
Mar 6, 2024
aduh95
approved these changes
Mar 6, 2024
bnb
approved these changes
Mar 6, 2024
richardlau
approved these changes
Mar 6, 2024
marco-ippolito
approved these changes
Mar 6, 2024
anonrig
approved these changes
Mar 6, 2024
legendecas
approved these changes
Mar 6, 2024
lpinca
approved these changes
Mar 6, 2024
tniessen
approved these changes
Mar 6, 2024
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
This is required since version 4 of the action (except for pull requests opened from forks). Refs: https://github.com/codecov/codecov-action/blob/e7748388508dfb57a188b1593a92c9ca8d865365/README.md#v4-release PR-URL: #51982 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required since version 4 of the action (except for pull requests opened from forks).
Refs: https://github.com/codecov/codecov-action/blob/e7748388508dfb57a188b1593a92c9ca8d865365/README.md#v4-release