FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

watch: batch file restarts by MoLow · Pull Request #51992 · nodejs/node · GitHub

/ node Public

watch: batch file restarts - #51992

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:watch-mode-lock-restart
Mar 9, 2024
ConversationCommits (1)ChecksFiles changed
Merged

watch: batch file restarts#51992
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:watch-mode-lock-restart

Conversation

MoLow commented Mar 6, 2024

Copy link
Copy Markdown
Member

Fixes #51954

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 6, 2024
MoLow mentioned this pull request Mar 6, 2024
Closed
Linkgoron reviewed Mar 6, 2024
View reviewed changes
Comment thread lib/internal/main/watch_mode.js Outdated
Linkgoron reviewed Mar 6, 2024
View reviewed changes
Comment thread lib/internal/main/watch_mode.js Outdated

matthieusieben commented Mar 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

I am so disappointed.

I spent several hours posting an issue and went so far as to provide not one but 4 different ways to fix it. In response, I get no feed back and @MoLow starts taking things out of my hands and does the thing himself.

Great 👍

MoLow commented Mar 7, 2024

Copy link
Copy Markdown
Member Author

@matthieusieben I did not mean to take things out of your hands, I simply opened PRS just to propose a solution I thought was better to the problem.
I am happy with closing this PR and discussing your proposed solutions (that I think are incorrect) in #51954. I probably should have done that prior to opening this PR
I want to emphesise again there was no intent to leave you out of things, and that is why I added you as a co-author in 57ac709

MoLow closed this Mar 7, 2024

matthieusieben commented Mar 7, 2024

Copy link
Copy Markdown
Contributor

Look, this solution is clearly supperior to #51971 so just keep it. I just wished you helped me figure things out instead of doing it yourself.

MoLow mentioned this pull request Mar 7, 2024
Closed
This was referenced Mar 7, 2024
Closed
Closed

MoLow commented Mar 7, 2024

Copy link
Copy Markdown
Member Author

@matthieusieben I intend to re-open and add you as a co-author. please confirm you are ok with being added as a co-author

matthieusieben commented Mar 7, 2024

Copy link
Copy Markdown
Contributor

I confirm. Thank you

watch: batch file restarts
a38e4a8 
Co-authored-by: Matthieu <matthieusieben@users.noreply.github.com>
MoLow reopened this Mar 7, 2024
MoLow force-pushed the watch-mode-lock-restart branch from 897f07c to a38e4a8 Compare March 7, 2024 16:21
MoLow requested review from Linkgoron, atlowChemi and benjamingr and removed request for atlowChemi and benjamingr March 7, 2024 16:21
atlowChemi added request-ci Add this label to start a Jenkins CI on a PR. watch-mode Issues and PRs related to watch mode labels Mar 7, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 7, 2024

nodejs-github-bot commented Mar 7, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57622/

MoLow added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 7, 2024

nodejs-github-bot commented Mar 7, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57626/

nodejs-github-bot commented Mar 7, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57628/

matthieusieben mentioned this pull request Mar 8, 2024
Closed

nodejs-github-bot commented Mar 9, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57644/

MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 9, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 9, 2024
nodejs-github-bot merged commit 257f322 into nodejs:main Mar 9, 2024

nodejs-github-bot commented Mar 9, 2024

Copy link
Copy Markdown
Collaborator

Landed in 257f322

MoLow deleted the watch-mode-lock-restart branch March 9, 2024 22:03
RafaelGSS mentioned this pull request Apr 15, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
watch: batch file restarts
508e968 
Co-authored-by: Matthieu <matthieusieben@users.noreply.github.com>
PR-URL: #51992
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
marco-ippolito mentioned this pull request May 2, 2024
Merged

andres290487 commented Jun 11, 2025

Copy link
Copy Markdown

Download and install Homebrew

curl -o- https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh | bash

Download and install Node.js:

brew install node@22

Verify the Node.js version:

node -v # Should print "v22.16.0".

Verify npm version:

npm -v # Should print "10.9.2".

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

benjamingr benjamingr approved these changes
atlowChemi atlowChemi approved these changes
+1 more reviewer
Linkgoron Linkgoron approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. watch-mode Issues and PRs related to watch mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

watch should debounce the restart

7 participants

Back | FazBrowse Home | New Git URL