test_runner: avoid overwriting root start time - #52020
Merged
nodejs-github-bot merged 1 commit intoMar 11, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This commit ensures the root test start time is not overwritten when top level before()/after() hooks are run.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
lpinca
approved these changes
Mar 9, 2024
atlowChemi
approved these changes
Mar 9, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
MoLow
approved these changes
Mar 9, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
This commit ensures the root test start time is not overwritten when top level before()/after() hooks are run. PR-URL: #52020 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit ensures the root test start time is not overwritten when top level before()/after() hooks are run.