crypto: fix input validation in crypto.hash - #52070
Merged
aduh95 merged 1 commit intoMar 21, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
H4ad
approved these changes
Mar 14, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Mar 15, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/52070 ✔ Done loading data for nodejs/node/pull/52070 ----------------------------------- PR info ------------------------------------ Title crypto: fix `input` validation in `crypto.hash` (#52070) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:crypto-hash-input-validation -> nodejs:main Labels crypto, author ready, needs-ci Commits 1 - crypto: fix `input` validation in `crypto.hash` Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/52070 Fixes: https://github.com/nodejs/node/pull/51044/files#r1522362983 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52070 Fixes: https://github.com/nodejs/node/pull/51044/files#r1522362983 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 13 Mar 2024 10:43:24 GMT ✔ Approvals: 2 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/52070#pullrequestreview-1935501284 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/52070#pullrequestreview-1940343564 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-03-15T20:05:29Z: https://ci.nodejs.org/job/node-test-pull-request/57770/ - Querying data for job/node-test-pull-request/57770/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 52070 From https://github.com/nodejs/node * branch refs/pull/52070/merge -> FETCH_HEAD ✔ Fetched commits as 0a252c23d904..67bed235d4fb -------------------------------------------------------------------------------- Auto-merging doc/api/crypto.md [main f90feb8b5b] crypto: fix `input` validation in `crypto.hash` Author: Antoine du Hamel Date: Wed Mar 13 11:39:22 2024 +0100 1 file changed, 2 insertions(+), 3 deletions(-) ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- crypto: fix `input` validation in `crypto.hash`https://github.com/nodejs/node/actions/runs/8373759766 |
Sorry, something went wrong.
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
PR-URL: #52070 Refs: https://github.com/nodejs/node/pull/51044/files#r1522362983 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
PR-URL: #52070 Refs: https://github.com/nodejs/node/pull/51044/files#r1522362983 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation was wrong as it was mentioning ArrayBuffer, and the error message was wrong as it wasn't mentioning string.
Fixes: https://github.com/nodejs/node/pull/51044/files#r1522362983