FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: improve event-loop promise state tracking by Uzlopak · Pull Request #52108 · nodejs/node · GitHub

/ node Public

fix: improve event-loop promise state tracking - #52108

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Uzlopak:improve-event-loop
May 6, 2024
ConversationCommits (1)ChecksFiles changed
Merged

fix: improve event-loop promise state tracking#52108
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Uzlopak:improve-event-loop

Conversation

Uzlopak commented Mar 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #43655
Fixes #34851
Superseeds #34862

@nodejs/performance

Can you help me with the changes in my last commit? I adapted changes from #34862. This should improve the performance of rejected promises. Maybe you have some concerns regarding the the changes. I am not that convinced from the last commit.

Ty

nodejs-github-bot added needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Mar 15, 2024
Uzlopak changed the title chore: improve event-loop chore: improve event-loop promise state tracking Mar 15, 2024
Uzlopak force-pushed the improve-event-loop branch 3 times, most recently from b4b0a4c to d221af4 Compare March 16, 2024 03:02
aduh95 reviewed Mar 16, 2024
View reviewed changes
Comment thread lib/internal/process/promises.js Outdated
Uzlopak mentioned this pull request Mar 17, 2024
Closed
Uzlopak changed the title chore: improve event-loop promise state tracking fix: improve event-loop promise state tracking Mar 17, 2024
Uzlopak requested a review from aduh95 March 17, 2024 17:07
mcollina approved these changes Mar 18, 2024
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2024

mcollina commented Mar 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

I think we should remove multipleResolves event in a follow-up PR.

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2024

nodejs-github-bot commented Mar 18, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57801/

nodejs-github-bot commented Mar 19, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57840/

Uzlopak commented Mar 20, 2024

Copy link
Copy Markdown
Contributor Author

@mcollina
@anonrig

Is there something i have to do?

aduh95 commented Mar 20, 2024

Copy link
Copy Markdown
Contributor

Yes, the added test is flaky:

not ok 2290 parallel/test-promise-unhandled-issue-43655
  ---
  duration_ms: 1031.49800
  severity: fail
  exitcode: 1
  stack: |-
    node:internal/process/promises:417
        triggerUncaughtException(err, true /* fromPromise */);
        ^
    
    AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
    
      assert.ok(Date.now() - time0 < 10)
    
        at test (/Users/iojs/build/workspace/node-test-commit-osx-arm/nodes/osx11/test/parallel/test-promise-unhandled-issue-43655.js:23:10) {
      generatedMessage: true,
      code: 'ERR_ASSERTION',
      actual: false,
      expected: true,
      operator: '=='
    }
    
    Node.js v22.0.0-pre
  ...

nodejs-github-bot commented Mar 20, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57865/

This comment was marked as outdated.

Sign in to view
Uzlopak force-pushed the improve-event-loop branch from 13e0e13 to 014d1b5 Compare March 21, 2024 02:13

Uzlopak commented Mar 21, 2024

Copy link
Copy Markdown
Contributor Author

It should be now less flaky.

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2024
mcollina approved these changes Apr 7, 2024
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2024

nodejs-github-bot commented Apr 7, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58178/

mertcanaltin approved these changes Apr 12, 2024
View reviewed changes

mertcanaltin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

benjamingr reviewed Apr 12, 2024
View reviewed changes
Comment thread lib/internal/process/promises.js Outdated
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 23, 2024

nodejs-github-bot commented Apr 23, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58645/

Uzlopak commented Apr 24, 2024

Copy link
Copy Markdown
Contributor Author

Are the test failures related to my patch? I have no osx-arm machine to check it.

Uzlopak force-pushed the improve-event-loop branch 2 times, most recently from 71b3502 to 691b724 Compare April 24, 2024 12:27

BridgeAR commented Apr 24, 2024

Copy link
Copy Markdown
Member

@Uzlopak they do not seem to be related

BridgeAR reviewed Apr 24, 2024
View reviewed changes
Comment thread lib/internal/process/promises.js Outdated
Uzlopak force-pushed the improve-event-loop branch from 691b724 to a5dc9a3 Compare May 6, 2024 03:22

Uzlopak commented May 6, 2024

Copy link
Copy Markdown
Contributor Author

@BridgeAR
PTAL

Uzlopak force-pushed the improve-event-loop branch from a5dc9a3 to 6fd930b Compare May 6, 2024 03:52
benjamingr approved these changes May 6, 2024
View reviewed changes

benjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Still lgtm

benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2024

nodejs-github-bot commented May 6, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58983/

nodejs-github-bot commented May 6, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58989/

Uzlopak commented May 6, 2024

Copy link
Copy Markdown
Contributor Author

Whoa!!!! the CI is green. the CI is green!

H4ad added the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2024
nodejs-github-bot merged commit be8d64e into nodejs:main May 6, 2024

nodejs-github-bot commented May 6, 2024

Copy link
Copy Markdown
Collaborator

Landed in be8d64e

Uzlopak deleted the improve-event-loop branch May 6, 2024 20:18
targos pushed a commit that referenced this pull request May 8, 2024
process: improve event-loop
0bbc62c 
PR-URL: #52108
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos mentioned this pull request May 13, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
process: improve event-loop
121ea13 
PR-URL: #52108
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
marco-ippolito mentioned this pull request Jun 17, 2024
Merged
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
process: improve event-loop
e1c475c 
PR-URL: nodejs#52108
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

BridgeAR BridgeAR left review comments
mcollina mcollina approved these changes
benjamingr benjamingr approved these changes
anonrig anonrig approved these changes
aduh95 Awaiting requested review from aduh95
+1 more reviewer
mertcanaltin mertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Problem with GC (million promise rejections) Promise Rejections delay process exiting (and others) in processPromiseRejections

10 participants

Back | FazBrowse Home | New Git URL