FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: make sure clear the old timer in http server by theanarkh · Pull Request #52118 · nodejs/node · GitHub

/ node Public

lib: make sure clear the old timer in http server - #52118

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
theanarkh:clear_old_timer_of_http_server
Mar 19, 2024
ConversationCommits (1)ChecksFiles changed
Merged

lib: make sure clear the old timer in http server#52118
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
theanarkh:clear_old_timer_of_http_server

Conversation

theanarkh commented Mar 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Currently we can call listen twice with same server in cluster worker and the server will emit listening event twice.
The http server will call setInterval inlistening event handler, but the second call do not clear the old timer which will make the memory leak.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot commented Mar 16, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Mar 16, 2024
theanarkh mentioned this pull request Mar 16, 2024
Merged
4 tasks
mcollina approved these changes Mar 18, 2024
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2024

nodejs-github-bot commented Mar 18, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57804/

theanarkh added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 18, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 19, 2024
nodejs-github-bot merged commit 4e9ce7c into nodejs:main Mar 19, 2024

nodejs-github-bot commented Mar 19, 2024

Copy link
Copy Markdown
Collaborator

Landed in 4e9ce7c

RafaelGSS mentioned this pull request Apr 15, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
lib: make sure clear the old timer in http server
abca33f 
PR-URL: #52118
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
marco-ippolito mentioned this pull request May 2, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
lib: make sure clear the old timer in http server
d33fc36 
PR-URL: #52118
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
ShogunPanda ShogunPanda approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL