test: add test for using --print with promises - #52137
Merged
nodejs-github-bot merged 1 commit intoMar 19, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
H4ad
approved these changes
Mar 18, 2024
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @H4ad. Please 👍 to approve. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
debadree25
approved these changes
Mar 19, 2024
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/52137 ✔ Done loading data for nodejs/node/pull/52137 ----------------------------------- PR info ------------------------------------ Title test: add test for using `--print` with promises (#52137) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:test-print-promises -> nodejs:main Labels test, fast-track, author ready, needs-ci Commits 1 - test: add test for using `--print` with promises Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/52137 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Debadree Chatterjee ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52137 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Debadree Chatterjee -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 18 Mar 2024 16:50:48 GMT ✔ Approvals: 2 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/52137#pullrequestreview-1943700516 ✔ - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/52137#pullrequestreview-1945219478 ℹ This PR is being fast-tracked ✘ This PR needs to wait 33 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-03-18T19:39:37Z: https://ci.nodejs.org/job/node-test-pull-request/57819/ - Querying data for job/node-test-pull-request/57819/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/8338760734 |
Sorry, something went wrong.
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
PR-URL: #52137 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
PR-URL: #52137 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a handful of tests that validate the current behavior of node.