FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

toosl: fix error reported by coverity in js2c.cc by mhdawson · Pull Request #52142 · nodejs/node · GitHub

/ node Public

toosl: fix error reported by coverity in js2c.cc - #52142

Closed
mhdawson wants to merge 1 commit into
nodejs:mainfrom
mhdawson:coverity-46
Closed

toosl: fix error reported by coverity in js2c.cc#52142
mhdawson wants to merge 1 commit into
nodejs:mainfrom
mhdawson:coverity-46

Conversation

Copy link
Copy Markdown
Member

Coverity reported using the wrong argument types
to printf

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 18, 2024

Copy link
Copy Markdown
Member Author

reports from coverity

}
614
615  if (simplified_count > 0) {
     	CID 347888:Invalid type in argument to printf format specifier (PRINTF_ARGS) [ "select issue" ]
616    Debug("Simplified %d characters, ", simplified_count);
     	
CID 347889: (#1 of 1): Invalid type in argument to printf format specifier (PRINTF_ARGS)
invalid_type: Argument code_size to format specifier %d was expected to have type int but has type unsigned long.["show details"]
     	CID 347887:Invalid type in argument to printf format specifier (PRINTF_ARGS) [ "select issue" ]
617    Debug("old size %d, new size %d\n", code_size, simplified->size());
618    return true;
619  }
620  return false;

Coverity reported using the wrong argument types
to printf

Signed-off-by: Michael Dawson <midawson@redhat.com>

meyfa commented Mar 19, 2024

Copy link
Copy Markdown
Contributor

There's a typo in the PR title 😅

Copy link
Copy Markdown
Member Author

@meyfa had already fixed the typo in the commit, but just fixed in the PR title.

mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 20, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 20, 2024

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

mhdawson added a commit that referenced this pull request Mar 25, 2024
Coverity reported using the wrong argument types
to printf

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #52142
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Copy link
Copy Markdown
Member Author

Landed in Landed in c43a944

mhdawson closed this Mar 25, 2024
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
Coverity reported using the wrong argument types
to printf

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #52142
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
Coverity reported using the wrong argument types
to printf

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #52142
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL