FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix `--env-file` docs to contain the valid quotes by dygabo · Pull Request #52157 · nodejs/node · GitHub

/ node Public

doc: fix --env-file docs to contain the valid quotes - #52157

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
dygabo:doc-env-file-update
Mar 23, 2024
Merged

doc: fix --env-file docs to contain the valid quotes #52157
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
dygabo:doc-env-file-update

Conversation

dygabo commented Mar 19, 2024

Copy link
Copy Markdown
Member

this just fixes a typo in the docs saying that \ can be used in .env files to define variable values.
Instead, backtick ` should be a vvalid value for that

nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Mar 19, 2024
dygabo force-pushed the doc-env-file-update branch from 36681c4 to 4b248f4 Compare March 19, 2024 16:42

aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

`

aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 20, 2024

UlisesGascon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 23, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 23, 2024
nodejs-github-bot merged commit 305375a into nodejs:main Mar 23, 2024

Copy link
Copy Markdown
Collaborator

Landed in 305375a

dygabo deleted the doc-env-file-update branch April 2, 2024 10:10
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
PR-URL: #52157
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
PR-URL: #52157
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL