src: use S_ISDIR to check if the file is dir - #52164
Merged
aduh95 merged 1 commit intoMay 12, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
theanarkh
force-pushed
the
fix_fs_is_dir
branch
from
c15f782 to
85bd2b6
Compare
March 20, 2024 12:41
This comment was marked as outdated.
theanarkh
force-pushed
the
fix_fs_is_dir
branch
2 times, most recently
from
655ebd7 to
5accbc2
Compare
March 21, 2024 13:31
This comment was marked as outdated.
lpinca
approved these changes
Mar 21, 2024
This comment was marked as outdated.
theanarkh
force-pushed
the
fix_fs_is_dir
branch
from
5accbc2 to
722ffe4
Compare
March 22, 2024 02:15
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
theanarkh
force-pushed
the
fix_fs_is_dir
branch
from
722ffe4 to
3e27d8f
Compare
March 25, 2024 12:25
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
theanarkh
force-pushed
the
fix_fs_is_dir
branch
from
6538b85 to
b386e97
Compare
April 21, 2024 15:58
This comment was marked as outdated.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Apr 27, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Failed to start CI⚠ Something was pushed to the Pull Request branch since the last approving review. ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/8952250038 |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Merged
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#52164 Fixes: nodejs#52159 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #52159