FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: improvements to console.markdown copy by estliberitas · Pull Request #5225 · nodejs/node · GitHub

/ node Public

doc: improvements to console.markdown copy - #5225

Closed
estliberitas wants to merge 1 commit into
nodejs:masterfrom
estliberitas:doc-fix-console
ConversationCommits (1)ChecksFiles changed
Closed

doc: improvements to console.markdown copy#5225
estliberitas wants to merge 1 commit into
nodejs:masterfrom
estliberitas:doc-fix-console

Conversation

estliberitas commented Feb 14, 2016

Copy link
Copy Markdown
Contributor

Fix missing links. Fix styling of printf() - once #5073 lands, link to man page will be auto-generated. Fix several typos.

mscdex reviewed Feb 14, 2016
View reviewed changes
Comment thread doc/api/console.markdown Outdated

mscdex Feb 14, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Maybe this should instead be:

... to write to `process.stdout` and `process.stderr`.

estliberitas Feb 14, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yep, I thought so too, but was waiting for this comment 😄

estliberitas Feb 14, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done

mscdex added doc Issues and PRs related to the documentations. console Issues and PRs related to the console subsystem. labels Feb 14, 2016
silverwind reviewed Feb 15, 2016
View reviewed changes
Comment thread doc/api/console.markdown Outdated

silverwind Feb 15, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hmm, multiple places in this file refer to the standard output streams as just stdout, stderr. I think it's better to keep this paragraph unchanged for consistency.

estliberitas Feb 15, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@mscdex your thoughts? I agree with both of you, to say, so not sure. From one point, it's OK to use stdout or "process stdout" because, it's how it is. Other point is let people understand that global console uses process.stdout and process.stderr Writable streams. Both points are good to me.

mscdex Feb 15, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I guess I don't really mind either way, as long as it's all consistent.

estliberitas Feb 15, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@mscdex @silverwind Fixed.

doc: improvements to console.markdown copy
0314d91 
Fix missing links. Fix styling of printf() - once #5073 lands,
link to man page will be auto-generated. Fix several typos.

silverwind commented Feb 16, 2016

Copy link
Copy Markdown
Contributor

LGTM

1 similar comment

jasnell commented Feb 16, 2016

Copy link
Copy Markdown
Member

LGTM

silverwind commented Feb 17, 2016

Copy link
Copy Markdown
Contributor

Landed in fb502ef.

silverwind closed this Feb 17, 2016
silverwind pushed a commit that referenced this pull request Feb 17, 2016
doc: improvements to console.markdown copy
fb502ef 
Fix missing links. Fix styling of printf() - once #5073 lands,
link to man page will be auto-generated. Fix several typos.

PR-URL: #5225
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Feb 18, 2016
doc: improvements to console.markdown copy
22f132e 
Fix missing links. Fix styling of printf() - once #5073 lands,
link to man page will be auto-generated. Fix several typos.

PR-URL: #5225
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added land-on-v4.x and removed doc Issues and PRs related to the documentations. labels Feb 22, 2016
MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
doc: improvements to console.markdown copy
7694081 
Fix missing links. Fix styling of printf() - once #5073 lands,
link to man page will be auto-generated. Fix several typos.

PR-URL: #5225
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
doc: improvements to console.markdown copy
d15ef20 
Fix missing links. Fix styling of printf() - once #5073 lands,
link to man page will be auto-generated. Fix several typos.

PR-URL: #5225
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
estliberitas deleted the doc-fix-console branch February 27, 2016 18:49
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
doc: improvements to console.markdown copy
388f1bb 
Fix missing links. Fix styling of printf() - once #5073 lands,
link to man page will be auto-generated. Fix several typos.

PR-URL: #5225
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

console Issues and PRs related to the console subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL