FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

crypto: validate RSA-PSS saltLength in subtle.sign and subtle.verify by panva · Pull Request #52262 · nodejs/node · GitHub

/ node Public

crypto: validate RSA-PSS saltLength in subtle.sign and subtle.verify - #52262

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:webcrypto-validate-saltLength
Apr 3, 2024
ConversationCommits (1)ChecksFiles changed
Merged

crypto: validate RSA-PSS saltLength in subtle.sign and subtle.verify#52262
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:webcrypto-validate-saltLength

Conversation

panva commented Mar 29, 2024

Copy link
Copy Markdown
Member

Resolves a TODO from @jasnell to validate RSA-PSS saltLength in SubtleCrypto.sign and SubtleCrypto.verify

fixes: #52188

panva added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. webcrypto labels Mar 29, 2024

nodejs-github-bot commented Mar 29, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

panva requested review from jasnell and tniessen March 29, 2024 15:25
panva added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 29, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 29, 2024

nodejs-github-bot commented Mar 29, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57999/

nodejs-github-bot commented Mar 29, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58000/

nodejs-github-bot commented Mar 29, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58001/

anonrig reviewed Mar 29, 2024
View reviewed changes
Comment thread lib/internal/crypto/rsa.js
const type = mode === kSignJobModeSign ? 'private' : 'public';

if (key.type !== type)
throw lazyDOMException(`Key must be a ${type} key`, 'InvalidAccessError');

anonrig Mar 29, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The error is not sync anymore. Does this make this semver-major change?

panva Mar 30, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It does not. The entire API surface of webcrypto is async functions.

Comment thread lib/internal/crypto/util.js
case 'SHA-1': return 20;
case 'SHA-256': return 32;
case 'SHA-384': return 48;
case 'SHA-512': return 64;

anonrig Mar 29, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you add a default with unreachable (like throw error)

panva Mar 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It's done the same way as the method above. I don't feel it's necessary. Used hashes are verified far before this is ever invoked.

panva requested a review from anonrig April 2, 2024 13:09
panva added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 3, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 3, 2024
nodejs-github-bot merged commit 2241e8c into nodejs:main Apr 3, 2024

nodejs-github-bot commented Apr 3, 2024

Copy link
Copy Markdown
Collaborator

Landed in 2241e8c

panva deleted the webcrypto-validate-saltLength branch April 3, 2024 07:45
RafaelGSS mentioned this pull request Apr 15, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
crypto: validate RSA-PSS saltLength in subtle.sign and subtle.verify
956e8fc 
fixes: #52188
PR-URL: #52262
Fixes: #52188
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
marco-ippolito mentioned this pull request May 2, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
crypto: validate RSA-PSS saltLength in subtle.sign and subtle.verify
197b61f 
fixes: #52188
PR-URL: #52262
Fixes: #52188
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
anonrig anonrig approved these changes
tniessen tniessen approved these changes
jasnell Awaiting requested review from jasnell

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. webcrypto

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

node:crypto RSA-PSS seems to be broken

5 participants

Back | FazBrowse Home | New Git URL