streams: fix util inspect returning undefined for CompressionStream and DecompressionStream - #52272
Closed
mertcanaltin wants to merge 0 commit into
Closed
streams: fix util inspect returning undefined for CompressionStream and DecompressionStream#52272mertcanaltin wants to merge 0 commit into
mertcanaltin wants to merge 0 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Can you please remove the merge commit and add a test? |
Sorry, something went wrong.
lpinca
approved these changes
Mar 30, 2024
Copy link
Copy Markdown
Member
Author
|
I'll take a look at this, it's so weird I'm committing and it's disappearing @lpinca |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
https://github.com/nodejs/node/blob/021cf912084005f4ecd7db06e0bad75353067a46/test/parallel/test-whatwg-webstreams-compression.js#L1C2-L74C6 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The customInspect method within the internal module node/lib/internal/webstreams/compression.js was missing a return statement, causing util.inspect to return undefined when inspecting instances of CompressionStream and DecompressionStream. This commit adds the missing return statement to ensure that util.inspect displays the correct information for these stream instances.
#52263