doc: fix email pattern to be wrapped with << instead of single < - #52284
Merged
nodejs-github-bot merged 1 commit intoMar 31, 2024
Merged
doc: fix email pattern to be wrapped with << instead of single <#52284nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @rluvaton. Please 👍 to approve. |
Sorry, something went wrong.
zcbenz
approved these changes
Mar 30, 2024
zcbenz
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/52284 ✔ Done loading data for nodejs/node/pull/52284 ----------------------------------- PR info ------------------------------------ Title doc: fix email pattern to be wrapped with `<<` instead of single `<` (#52284) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch rluvaton:fix-email -> nodejs:main Labels doc, fast-track Commits 1 - doc: fix email pattern to be wrapped with `<<` instead of single `<` Committers 1 - Raz Luvaton <16746759+rluvaton@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/52284 ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52284 -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 30 Mar 2024 21:33:34 GMT ✘ Approvals: 0 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/8494208088 |
Sorry, something went wrong.
VoltrexKeyva
approved these changes
Mar 31, 2024
Copy link
Copy Markdown
Contributor
|
@zcbenz note that fast-tracking PRs require 2 upvotes (2 thumbs up reactions on GitHub Actions bot's comment). Documented here:
|
Sorry, something went wrong.
anonrig
approved these changes
Mar 31, 2024
benjamingr
approved these changes
Mar 31, 2024
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
PR-URL: #52284 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
PR-URL: #52284 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the email should be wrapped with <<{email}>> and not <{email}>
node/tools/find-inactive-collaborators.mjs
Line 82 in 0408f63