deps: update c-ares to 1.28.1 - #52285
Merged
nodejs-github-bot merged 3 commits intoApr 4, 2024
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
It seems that the build failures are caused by the use of deprecated functions. We should replace ares_parse_* with ares_dns_parse() and ares_get_servers_ports() with ares_get_servers_ports_csv(). |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
cc: @nodejs/dns |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Using ares_{get,set}_servers{,_ports}_csv() does not make much sense to me. Should we use -Wno-error=deprecated-declarations? cc: @bradh352 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Yeah, I'd still recommend letting those warnings be emitted in the hopes that at some point someone will do the conversions to the modern functions, just not error out on those warnings. But if you really don't want those warnings to be emitted at all, you can use the CPPFLAG of -DCARES_NO_DEPRECATED. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Btw the reason why we recommend ares_get_servers_ports_csv() instead of ares_get_servers_ports() is because ares_get_servers_ports() can't return additional information like link-local dns servers %iface syntax. In the future, we'll probably also implement the #domain syntax for domain-specific DNS servers where CSV would output that format. |
Sorry, something went wrong.
lpinca
force-pushed
the
actions/tools-update-c-ares
branch
from
61e66f0 to
736113b
Compare
March 31, 2024 16:46
Copy link
Copy Markdown
Collaborator
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
Sorry, something went wrong.
lpinca
approved these changes
Apr 4, 2024
aduh95
approved these changes
Apr 4, 2024
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
PR-URL: #52285 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
PR-URL: #52285 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 8, 2024
jkleinsc
pushed a commit
to electron/electron
that referenced
this pull request
May 13, 2024
* chore: bump node in DEPS to v20.13.0 * crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL nodejs/node#52217 * test: skip test for dynamically linked OpenSSL nodejs/node#52542 * lib, url: add a `windows` option to path parsing nodejs/node#52509 * src: use dedicated routine to compile function for builtin CJS loader nodejs/node#52016 * test: mark test as flaky nodejs/node#52671 * build,tools: add test-ubsan ci nodejs/node#46297 * src: preload function for Environment nodejs/node#51539 * chore: fixup patch indices * deps: update c-ares to 1.28.1 nodejs/node#52285 * chore: handle updated filenames - nodejs/node#51999 - nodejs/node#51927 * chore: bump node in DEPS to v20.13.1 * events: extract addAbortListener for safe internal use nodejs/node#52081 * module: print location of unsettled top-level await in entry points nodejs/node#51999 * fs: add stacktrace to fs/promises nodejs/node#49849 * chore: update patches --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
richardlau
pushed a commit
that referenced
this pull request
May 16, 2024
PR-URL: #52285 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 31, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 31, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 31, 2024
* chore: bump node in DEPS to v20.13.1 * chore: bump node in DEPS to v20.14.0 * crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL nodejs/node#52217 * test: skip test for dynamically linked OpenSSL nodejs/node#52542 * lib, url: add a `windows` option to path parsing nodejs/node#52509 * src: use dedicated routine to compile function for builtin CJS loader nodejs/node#52016 * test: mark test as flaky nodejs/node#52671 * build,tools: add test-ubsan ci nodejs/node#46297 * src: preload function for Environment nodejs/node#51539 * chore: fixup patch indices * deps: update c-ares to 1.28.1 nodejs/node#52285 * chore: handle updated filenames * events: extract addAbortListener for safe internal use nodejs/node#52081 * module: print location of unsettled top-level await in entry points nodejs/node#51999 * fs: add stacktrace to fs/promises nodejs/node#49849 * chore: fixup patch indices --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jun 1, 2024
* chore: bump node in DEPS to v20.13.1 * chore: bump node in DEPS to v20.14.0 * chore: update build_add_gn_build_files.patch * chore: update patches * chore: update patches * build: encode non-ASCII Latin1 characters as one byte in JS2C nodejs/node#51605 * crypto: use EVP_MD_fetch and cache EVP_MD for hashes nodejs/node#51034 * chore: update filenames.json * chore: update patches * src: support configurable snapshot nodejs/node#50453 * test: remove test-domain-error-types flaky designation nodejs/node#51717 * src: avoid draining platform tasks at FreeEnvironment nodejs/node#51290 * chore: fix accidentally deleted v8 dep * lib: define FormData and fetch etc. in the built-in snapshot nodejs/node#51598 * chore: remove stray log * crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL nodejs/node#52217 * test: skip test for dynamically linked OpenSSL nodejs/node#52542 * lib, url: add a `windows` option to path parsing nodejs/node#52509 * src: use dedicated routine to compile function for builtin CJS loader nodejs/node#52016 * test: mark test as flaky nodejs/node#52671 * build,tools: add test-ubsan ci nodejs/node#46297 * src: preload function for Environment nodejs/node#51539 * deps: update c-ares to 1.28.1 nodejs/node#52285 * chore: fixup * events: extract addAbortListener for safe internal use nodejs/node#52081 * module: print location of unsettled top-level await in entry points nodejs/node#51999 * fs: add stacktrace to fs/promises nodejs/node#49849 * chore: fixup indices --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Cheng <zcbenz@gmail.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of c-ares to 1.28.1.