doc: replace "below" with "following" - #52315
Merged
nodejs-github-bot merged 2 commits intoApr 3, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
GeoffreyBooth
approved these changes
Apr 1, 2024
MoLow
approved these changes
Apr 1, 2024
Copy link
Copy Markdown
Member
Author
|
(We could probably split hairs over whether these particular uses are in violation of the text or spirit of the Microsoft Style Guide, but I think the changes here are better in any event. In my opinion, there's far less room for confusion in "the following code" as opposed to "below".) |
Sorry, something went wrong.
UlisesGascon
approved these changes
Apr 1, 2024
UlisesGascon
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
JakobJingleheimer
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
"Below" vs "following" (i saw the cited doc) seems an inconsequential difference but sure, no better or worse.
Sorry, something went wrong.
Comment thread
doc/api/addons.md
Outdated
Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>
trivikr
approved these changes
Apr 2, 2024
lpinca
approved these changes
Apr 2, 2024
aymen94
approved these changes
Apr 2, 2024
benjamingr
approved these changes
Apr 2, 2024
tniessen
approved these changes
Apr 2, 2024
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
Ref: https://learn.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/b/below PR-URL: #52315 Refs: https://learn.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/b/below Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
Ref: https://learn.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/b/below PR-URL: #52315 Refs: https://learn.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/b/below Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: https://learn.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/b/below