[v18.x] http: remove closeIdleConnections function while calling server close - #52334
Closed
kumarrishav wants to merge 1 commit into
Closed
[v18.x] http: remove closeIdleConnections function while calling server close#52334kumarrishav wants to merge 1 commit into
kumarrishav wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Do the server.closeIdleConnections calls deleted from the tests in #50194 need to be put back? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Yes, I believe that the those two tests should be reverted as well. |
Sorry, something went wrong.
Correcting the nodejs#50194 backporting mistake. closeIdleConnections shouldn't be called while server.close in node v18. This behavior is for node v19 and above. fixes: nodejs#52330, nodejs#51677,
Copy link
Copy Markdown
Contributor
Author
|
previous PR got messed up. @richardlau @Linkgoron opened a new PR #52336 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correcting the #50194 backporting mistake. server.closeIdleConnections shouldn't be called while server.close in node v18. This behavior is for node v19 and above.
fixes: #52330, #51677,
As discussed here: #48383 (comment)