watch: fix some node argument not passed to watched process - #52358
Merged
nodejs-github-bot merged 4 commits intoApr 7, 2024
Merged
watch: fix some node argument not passed to watched process#52358nodejs-github-bot merged 4 commits into
nodejs-github-bot merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
rluvaton
commented
Apr 3, 2024
Comment thread
test/sequential/test-watch-mode.mjs
Outdated
rluvaton
commented
Apr 3, 2024
Comment thread
test/sequential/test-watch-mode.mjs
Outdated
rluvaton
commented
Apr 3, 2024
Comment thread
test/sequential/test-watch-mode.mjs
Outdated
rluvaton
commented
Apr 3, 2024
Comment thread
test/sequential/test-watch-mode.mjs
Outdated
rluvaton
commented
Apr 3, 2024
Comment thread
test/sequential/test-watch-mode.mjs
Outdated
rluvaton
commented
Apr 3, 2024
Comment thread
test/sequential/test-watch-mode.mjs
Outdated
rluvaton
commented
Apr 3, 2024
Comment thread
test/sequential/test-watch-mode.mjs
Outdated
rluvaton
force-pushed
the
fix-watch-path-and-require
branch
from
b57291b to
5a4e308
Compare
April 3, 2024 23:07
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Comment thread
lib/internal/main/watch_mode.js
Outdated
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
MoLow
approved these changes
Apr 4, 2024
JakobJingleheimer
approved these changes
Apr 4, 2024
JakobJingleheimer
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
🙌
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
benjamingr
approved these changes
Apr 7, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
PR-URL: #52358 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
PR-URL: #52358 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some arguments were omitted instead of been sent to the spawned watched process