FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: update branch name in node_revert.h by tniessen · Pull Request #52390 · nodejs/node · GitHub

/ node Public

src: update branch name in node_revert.h - #52390

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:src-revert-branch-name
Apr 8, 2024
Merged

src: update branch name in node_revert.h#52390
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:src-revert-branch-name

Conversation

tniessen commented Apr 6, 2024

Copy link
Copy Markdown
Member

This comment is outdated.

tniessen added lib / src Issues and PRs related to general changes in the lib or src directory. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 6, 2024

github-actions Bot commented Apr 6, 2024

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Apr 6, 2024
richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 6, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 6, 2024

Copy link
Copy Markdown
Collaborator

tniessen commented Apr 6, 2024

Copy link
Copy Markdown
Member Author

CI is likely going to fail due to nodejs/build#3673.

Copy link
Copy Markdown
Collaborator

tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 8, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 8, 2024
nodejs-github-bot merged commit 9ef724b into nodejs:main Apr 8, 2024

Copy link
Copy Markdown
Collaborator

Landed in 9ef724b

marco-ippolito pushed a commit that referenced this pull request May 2, 2024
PR-URL: #52390
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
PR-URL: #52390
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL