test: simplify ASan build checks - #52430
Merged
nodejs-github-bot merged 2 commits intoApr 11, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Always use `process.config.variables.asan`. This removes the need for a special ASAN env var.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
aduh95
approved these changes
Apr 9, 2024
Comment thread
test/common/index.js
Outdated
richardlau
approved these changes
Apr 9, 2024
marco-ippolito
approved these changes
Apr 9, 2024
VoltrexKeyva
approved these changes
Apr 9, 2024
lpinca
approved these changes
Apr 9, 2024
anonrig
approved these changes
Apr 10, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
Always use `process.config.variables.asan`. This removes the need for a special ASAN env var. PR-URL: #52430 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
Always use `process.config.variables.asan`. This removes the need for a special ASAN env var. PR-URL: #52430 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always use process.config.variables.asan.
This removes the need for a special ASAN env var.