test: mitigate flaky test-debug-no-context - #5269
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Change test so that it passes on the occasional win10 access violation. The workaround here can be undone when issue 5268 is resolved. The test still detects the defect it was written to detect. There are two assertions that detect the defect and only one was disabled. Ref: nodejs#5268 Fixes: nodejs#4343
Copy link
Copy Markdown
Member
Author
|
Stress test showing current version of test is flaky on win10: 15 failures in 100 runs Stress test showing the version in this PR is not flaky on win10: 0 failures in 100 runs Output showing the version in this PR fails as expected with Node.js 5.3.0: $ nvm use 5.3
Now using node v5.3.0
$ node -v
v5.3.0
$ node test/parallel/test-debug-no-context.js
assert.js:89
throw new assert.AssertionError({
^
AssertionError: 'SIGSEGV' === null
at ChildProcess.<anonymous> (/Users/trott/io.js/test/parallel/test-debug-no-context.js:18:10)
at ChildProcess.<anonymous> (/Users/trott/io.js/test/common.js:382:15)
at emitTwo (events.js:87:13)
at ChildProcess.emit (events.js:172:7)
at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
$
Output showing the version in this PR passes as expected with Node.js 5.4.0: $ nvm use 5.4.0 Now using node v5.4.0 $ node -v v5.4.0 $ node test/parallel/test-debug-no-context.js $ |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@jasnell Actually, it is relevant. My mistake not labeling it. I've added lts-watch-4.x label. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thank you! :-) |
Sorry, something went wrong.
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 19, 2016
Change test so that it passes on the occasional win10 access violation. The workaround here can be undone when issue 5268 is resolved. The test still detects the defect it was written to detect. There are two assertions that detect the defect and only one was disabled. Ref: nodejs#5268 Fixes: nodejs#4343 PR-URL: nodejs#5269 Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 19, 2016
test-debug-no-context flakiness was worked around in issue 5269 but the flaky designation was left for the test. This change removes it. Refs: nodejs#5269
rvagg
pushed a commit
that referenced
this pull request
Feb 21, 2016
Change test so that it passes on the occasional win10 access violation. The workaround here can be undone when issue 5268 is resolved. The test still detects the defect it was written to detect. There are two assertions that detect the defect and only one was disabled. Ref: #5268 Fixes: #4343 PR-URL: #5269 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 1, 2016
Change test so that it passes on the occasional win10 access violation. The workaround here can be undone when issue 5268 is resolved. The test still detects the defect it was written to detect. There are two assertions that detect the defect and only one was disabled. Ref: #5268 Fixes: #4343 PR-URL: #5269 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 1, 2016
Change test so that it passes on the occasional win10 access violation. The workaround here can be undone when issue 5268 is resolved. The test still detects the defect it was written to detect. There are two assertions that detect the defect and only one was disabled. Ref: #5268 Fixes: #4343 PR-URL: #5269 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
Change test so that it passes on the occasional win10 access violation. The workaround here can be undone when issue 5268 is resolved. The test still detects the defect it was written to detect. There are two assertions that detect the defect and only one was disabled. Ref: #5268 Fixes: #4343 PR-URL: #5269 Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change test so that it passes on the occasional win10 access violation.
The workaround here can be undone when issue 5268 is resolved.
The test still detects the defect it was written to detect. There are
two assertions that detect the defect and only one was disabled.
Ref: #5268
Fixes: #4343
/cc @bnoordhuis