build: fix --v8-lite-mode build - #52725
Merged
nodejs-github-bot merged 1 commit intoJun 3, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thank you! |
Sorry, something went wrong.
anonrig
approved these changes
Apr 28, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Copy link
Copy Markdown
Member
Author
|
The CI test error seems to require a fix for #51308. 12:20:46 1480c755c560 8 JS:~functionTwo /home/iojs/build/workspace/node-test-commit-v8-linux/test/fixtures/linux-perf-logger.js:13:21
12:20:46 1480c755c600 3c JS:~functionOne /home/iojs/build/workspace/node-test-commit-v8-linux/test/fixtures/linux-perf-logger.js:7:21
12:20:46
12:20:46 </end perf map content>
12:20:46
12:20:46 at runSuite (/home/iojs/build/workspace/node-test-commit-v8-linux/test/v8-updates/test-linux-perf-logger.js:145:10)
12:20:46 at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-v8-linux/test/v8-updates/test-linux-perf-logger.js:148:1)
12:20:46 at Module._compile (node:internal/modules/cjs/loader:1476:14)
12:20:46 at Module._extensions..js (node:internal/modules/cjs/loader:1555:10)
12:20:46 at Module.load (node:internal/modules/cjs/loader:1288:32)
12:20:46 at Module._load (node:internal/modules/cjs/loader:1104:12)
12:20:46 at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:191:14)
12:20:46 at node:internal/main/run_main_module:30:49 {
12:20:46 generatedMessage: false,
12:20:46 code: 'ERR_ASSERTION',
12:20:46 actual: 2,
12:20:46 expected: 0,
12:20:46 operator: 'strictEqual'
12:20:46 }
12:20:46
12:20:46 Node.js v23.0.0-pre
12:20:46 ...
12:20:46
12:20:46 Failed tests:
12:20:46 out/Release/node /home/iojs/build/workspace/node-test-commit-v8-linux/test/v8-updates/test-linux-perf-logger.js
...
Failed tests:
out/Release/node /home/iojs/build/workspace/node-test-commit-v8-linux/test/v8-updates/test-linux-perf-logger.js
|
Sorry, something went wrong.
richardlau
approved these changes
Apr 29, 2024
lpinca
approved these changes
Apr 29, 2024
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
daeyeon
force-pushed
the
main.build-240428.Sun.5116
branch
from
dd1048e to
46be09a
Compare
June 3, 2024 01:56
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Rebased the latest main and all tests are green. Please review once more. @anonrig @lpinca @richardlau |
Sorry, something went wrong.
richardlau
approved these changes
Jun 3, 2024
Merged
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: nodejs#52725 Fixes: nodejs#52710 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #52710
This patch modifies the build config to compile the error-causing files under the v8_enable_webassembly condition.
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com