[v20.x backport] streams: implement TransformStream cleanup using "transformer.cancel" - #52772
Closed
MattiasBuelens wants to merge 1 commit into
Closed
[v20.x backport] streams: implement TransformStream cleanup using "transformer.cancel"#52772MattiasBuelens wants to merge 1 commit into
MattiasBuelens wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Fixes: nodejs#49971 PR-URL: nodejs#50126 Backport-PR-URL: nodejs#52772 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MattiasBuelens
force-pushed
the
backport-50126-to-v20.x
branch
2 times, most recently
from
207856f to
d36fbc3
Compare
May 1, 2024 10:32
marco-ippolito
approved these changes
May 1, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
mcollina
approved these changes
May 1, 2024
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
benjamingr
approved these changes
May 1, 2024
Copy link
Copy Markdown
Member
|
Landed in 3dd96f1fabf3 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #50126 to v20.x.
Fixes #49971