build: define NOMINMAX in common.gypi - #52794
Merged
nodejs-github-bot merged 1 commit intoMay 4, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
V8 and Node.js had defined `NOMINMAX` on Windows for a long time. In recent changes, V8 added `std::numeric_limits::min` usages in its header files which caused addons without `NOMINMAX` defines failed to compile. Define `NOMINMAX` in common.gypi so that addons can be compiled with the latest V8 header files.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
targos
approved these changes
May 2, 2024
agnat
approved these changes
May 2, 2024
agnat
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
VoltrexKeyva
approved these changes
May 2, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
anonrig
approved these changes
May 2, 2024
lpinca
approved these changes
May 2, 2024
gengjiawen
approved these changes
May 3, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks @legendecas ! Any idea when there'll be a 22.2.0 (or even 22.1.1) release that includes this so that nan users on Windows can be unblocked? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@mureinik Addons can be unblocked immediately with their own NOMINMAX definition. I didn't find any upcoming release plan at nodejs/Release#1001. @nodejs/releasers would you mind chiming in on this? Thank you! |
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
May 8, 2024
V8 and Node.js had defined `NOMINMAX` on Windows for a long time. In recent changes, V8 added `std::numeric_limits::min` usages in its header files which caused addons without `NOMINMAX` defines failed to compile. Define `NOMINMAX` in common.gypi so that addons can be compiled with the latest V8 header files. PR-URL: #52794 Fixes: nodejs/nan#968 Refs: nodejs/gyp-next#244 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
V8 and Node.js had defined `NOMINMAX` on Windows for a long time. In recent changes, V8 added `std::numeric_limits::min` usages in its header files which caused addons without `NOMINMAX` defines failed to compile. Define `NOMINMAX` in common.gypi so that addons can be compiled with the latest V8 header files. PR-URL: nodejs#52794 Fixes: nodejs/nan#968 Refs: nodejs/gyp-next#244 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
3 tasks
3 tasks
codebytere
added a commit
to electron/electron
that referenced
this pull request
Mar 3, 2025
3 tasks
codebytere
added a commit
to electron/electron
that referenced
this pull request
Mar 3, 2025
codebytere
added a commit
to electron/electron
that referenced
this pull request
Mar 3, 2025
This was referenced Mar 3, 2025
codebytere
added a commit
to electron/electron
that referenced
this pull request
Mar 3, 2025
jkleinsc
pushed a commit
to electron/electron
that referenced
this pull request
Mar 3, 2025
build: define NOMINMAX in common.gypi nodejs/node#52794
codebytere
added a commit
to electron/electron
that referenced
this pull request
Mar 3, 2025
build: define NOMINMAX in common.gypi nodejs/node#52794
codebytere
added a commit
to electron/electron
that referenced
this pull request
Mar 3, 2025
build: define NOMINMAX in common.gypi nodejs/node#52794
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V8 and Node.js had defined NOMINMAX on Windows for a long time. In
recent changes, V8 added std::numeric_limits::min usages in its
header files which caused addons without NOMINMAX defines failed
to compile.
Define NOMINMAX in common.gypi so that addons can be compiled with
the latest V8 header files.
NAN includes uv.h before node.h, which makes
these defines effectiveless. Nevertheless, the include order should not be
significant.
Fixes: nodejs/nan#968
Refs: nodejs/gyp-next#244