doc: fix buf.readInt16LE output - #5282
Conversation
Sorry, something went wrong.
Previous example didn't account for the 1 byte offset
| // returns 510 | ||
| buf.readInt16LE(1); | ||
| // returns -511 | ||
| // returns 1022 |
There was a problem hiding this comment.
I think the original intent was to read the same two bytes.
cc @jasnell who I believe added this example.
Sorry, something went wrong.
There was a problem hiding this comment.
Gotcha. Will update to whatever @jasnell thinks here
Sorry, something went wrong.
There was a problem hiding this comment.
Yep, this was a typo on my part... the second one should be buf.readInt16LE(); (no argument passed in)
Sorry, something went wrong.
There was a problem hiding this comment.
that said, this change works too
Sorry, something went wrong.
|
LGTM |
Sorry, something went wrong.
Previous example didn't account for the 1 byte offset PR-URL: #5282 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Previous example didn't account for the 1 byte offset PR-URL: #5282 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Previous example didn't account for the 1 byte offset PR-URL: #5282 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Previous example didn't account for the 1 byte offset PR-URL: #5282 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Previous example didn't account for the 1 byte offset PR-URL: #5282 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
No description provided.