dgram: do not call callback if socket is closed - #52829
Merged
nodejs-github-bot merged 1 commit intoMay 23, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/8949880553 |
Sorry, something went wrong.
mcollina
reviewed
May 6, 2024
Comment thread
test/parallel/test-dgram-bind-socket-close-before-cluster-reply.js
Outdated
ShogunPanda
reviewed
May 15, 2024
Comment thread
lib/dgram.js
Outdated
mcollina
approved these changes
May 15, 2024
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm so we can start CI
Sorry, something went wrong.
theanarkh
force-pushed
the
dont-emit-error-after-close-handle
branch
from
9aeee94 to
d022b6c
Compare
May 15, 2024 11:48
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/52829 ✔ Done loading data for nodejs/node/pull/52829 ----------------------------------- PR info ------------------------------------ Title dgram: do not call callback if socket is closed (#52829) Author theanarkh (@theanarkh) Branch theanarkh:dont-emit-error-after-close-handle -> nodejs:main Labels dgram, needs-ci Commits 1 - lib: do not call callback if socket is closed Committers 1 - theanarkh PR-URL: https://github.com/nodejs/node/pull/52829 Reviewed-By: Matteo Collina ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52829 Reviewed-By: Matteo Collina -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - lib: do not call callback if socket is closed ℹ This PR was created on Sat, 04 May 2024 07:58:48 GMT ✔ Approvals: 1 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/52829#pullrequestreview-2057177270 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-05-18T07:21:46Z: https://ci.nodejs.org/job/node-test-pull-request/59282/ - Querying data for job/node-test-pull-request/59282/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/9146455101 |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
mcollina
approved these changes
May 23, 2024
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Jun 1, 2024
PR-URL: #52829 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#52829 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #52829 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not call callback if socket is closed.