tools: update gyp-next to 0.18.0 - #52835
Closed
nodejs-github-bot wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
Review requested:
|
Sorry, something went wrong.
lpinca
approved these changes
May 5, 2024
cclauss
requested changes
May 5, 2024
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
These two commands fail on Python 3.12 with ModuleNotFoundError: No module named 'packaging'
% pipx run --spec git+https://github.com/nodejs/gyp-next.git gyp --help
% pipx run --spec git+https://github.com/nodejs/gyp-next.git gyp --version
This was fixed in the past by:
Also discussed in:
Sorry, something went wrong.
cclauss
approved these changes
May 9, 2024
Copy link
Copy Markdown
Collaborator
Author
Sorry, something went wrong.
targos
approved these changes
May 9, 2024
Copy link
Copy Markdown
Contributor
|
Should we wait on this fix for gyp --version on Python >= 3.12? |
Sorry, something went wrong.
cclauss
self-requested a review
May 9, 2024 14:20
Copy link
Copy Markdown
Member
|
I'd say no because it doesn't matter for the usage in this project |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
Sorry, something went wrong.
cclauss
approved these changes
May 9, 2024
legendecas
approved these changes
May 9, 2024
Copy link
Copy Markdown
Collaborator
Author
|
Landed in 70995bd...a923fed |
Sorry, something went wrong.
nodejs-github-bot
added a commit
that referenced
this pull request
May 9, 2024
PR-URL: #52835 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
nodejs-github-bot
added a commit
that referenced
this pull request
May 9, 2024
PR-URL: #52835 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 11, 2024
PR-URL: #52835 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 11, 2024
PR-URL: #52835 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Merged
Copy link
Copy Markdown
Member
|
this breaks v20.x build https://ci.nodejs.org/job/node-test-commit-linux/nodes=debian10-x64/58454/console |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Test is running on Python 3.7 which is no longer supported: Node.js configure: Found Python 3.7.3...
10:02:34 Traceback (most recent call last):
10:02:34 File "./configure", line 29, in <module>
10:02:34 import configure
10:02:34 File "/home/iojs/build/workspace/node-test-commit-linux/configure.py", line 30, in <module>
10:02:34 from gyp.common import GetFlavor
10:02:34 File "tools/gyp/pylib/gyp/__init__.py", line 9, in <module>
10:02:34 import gyp.input
10:02:34 File "tools/gyp/pylib/gyp/input.py", line 8, in <module>
10:02:34 import gyp.common
10:02:34 File "tools/gyp/pylib/gyp/common.py", line 435
10:02:34 if CC := os.environ.get("CC_target") or os.environ.get("CC"):
10:02:34 ^
10:02:34 SyntaxError: invalid syntax
Assignment expression https://docs.python.org/3/whatsnew/3.8.html |
Sorry, something went wrong.
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#52835 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#52835 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of gyp-next to 0.18.0.