FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fs: allow 'withFileTypes' to be used with globs by avivkeller · Pull Request #52837 · nodejs/node · GitHub

/ node Public

fs: allow 'withFileTypes' to be used with globs - #52837

Merged
nodejs-github-bot merged 8 commits into
nodejs:mainfrom
avivkeller:withfiletypes-glob
May 7, 2024
ConversationCommits (8)ChecksFiles changed
Merged

fs: allow 'withFileTypes' to be used with globs#52837
nodejs-github-bot merged 8 commits into
nodejs:mainfrom
avivkeller:withfiletypes-glob

Conversation

avivkeller commented May 5, 2024

Copy link
Copy Markdown
Member

Fixes #52752

This PR enables the usage of withFileTypes in fs.glob (and similar) functions.

When withFileTypes is provided, the exclude() function will receive Dirent objects as arguments, along with the return value and callbacks.

nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels May 5, 2024
MoLow reviewed May 5, 2024
View reviewed changes
Comment thread lib/internal/fs/glob.js Outdated
MoLow approved these changes May 5, 2024
View reviewed changes

MoLow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Lgtm

aduh95 reviewed May 5, 2024
View reviewed changes
Comment thread lib/internal/fs/glob.js Outdated
aduh95 reviewed May 5, 2024
View reviewed changes
Comment thread test/parallel/test-fs-glob.mjs Outdated
benjamingr approved these changes May 5, 2024
View reviewed changes

benjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

good work

avivkeller and others added 2 commits May 5, 2024 11:39
Update glob.js
b70ecc4 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Update test-fs-glob.mjs
0bd1e1b 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

avivkeller commented May 5, 2024

Copy link
Copy Markdown
Member Author

Thanks for the reviews! I'll fix the lint later today :-)

benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2024

nodejs-github-bot commented May 5, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58961/

targos reviewed May 5, 2024
View reviewed changes
Comment thread doc/api/fs.md Outdated
Comment thread doc/api/fs.md Outdated
Comment thread doc/api/fs.md Outdated
avivkeller and others added 3 commits May 5, 2024 14:26
Update doc/api/fs.md
75041e2 
Co-authored-by: Michaël Zasso <targos@protonmail.com>
Update doc/api/fs.md
bd621ca 
Co-authored-by: Michaël Zasso <targos@protonmail.com>
Update doc/api/fs.md
8d2e905 
Co-authored-by: Michaël Zasso <targos@protonmail.com>

nodejs-github-bot commented May 5, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58965/

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 5, 2024

targos commented May 6, 2024

Copy link
Copy Markdown
Member

That's a warning and can be ignored.

The actual error is fatal error C1060: compiler is out of heap space. This requires to Resume CI (I just did that)

nodejs-github-bot commented May 6, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58973/

nodejs-github-bot commented May 6, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58979/

nodejs-github-bot commented May 6, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58984/

nodejs-github-bot commented May 7, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59005/

nodejs-github-bot commented May 7, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59008/

MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label May 7, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 7, 2024
nodejs-github-bot merged commit 303c80c into nodejs:main May 7, 2024

nodejs-github-bot commented May 7, 2024

Copy link
Copy Markdown
Collaborator

Landed in 303c80c

avivkeller deleted the withfiletypes-glob branch May 7, 2024 11:17
targos pushed a commit that referenced this pull request May 8, 2024
fs: allow 'withFileTypes' to be used with globs
7d7a762 
PR-URL: #52837
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos added the semver-minor PRs that contain new features and should be released in the next minor version. label May 13, 2024

targos commented May 13, 2024

Copy link
Copy Markdown
Member

This PR adds a feature so it should be labeled semver-minor PRs that contain new features and should be released in the next minor version. (this is not supposed to be done by releasers).

targos added a commit that referenced this pull request May 13, 2024
2024-05-14, Version 22.2.0 (Current)
7d92816 
Notable changes:

cli:
  * (SEMVER-MINOR) allow running wasm in limited vmem with
    --disable-wasm-trap-handler (Joyee Cheung)
    #52766
doc:
  * add pimterry to collaborators (Tim Perry)
    #52874
fs:
  * (SEMVER-MINOR) allow 'withFileTypes' to be used with globs
    (Aviv Keller) #52837
inspector:
  * (SEMVER-MINOR) introduce the `--inspect-wait` flag (Kohei Ueno)
    #52734
lib,src:
  * remove --experimental-policy (Rafael Gonzaga)
    #52583
perf_hooks:
  * (SEMVER-MINOR) add `deliveryType` and `responseStatus` fields
    (Matthew Aitken) #51589
test_runner:
  * (SEMVER-MINOR) support test plans (Colin Ihrig)
    #52860
zlib:
  * (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung)
    #52692

PR-URL: #52971
targos mentioned this pull request May 13, 2024
Merged
targos added a commit that referenced this pull request May 15, 2024
2024-05-15, Version 22.2.0 (Current)
d57af10 
Notable changes:

cli:
  * (SEMVER-MINOR) allow running wasm in limited vmem with
    --disable-wasm-trap-handler (Joyee Cheung)
    #52766
doc:
  * add pimterry to collaborators (Tim Perry)
    #52874
fs:
  * (SEMVER-MINOR) allow 'withFileTypes' to be used with globs
    (Aviv Keller) #52837
inspector:
  * (SEMVER-MINOR) introduce the `--inspect-wait` flag (Kohei Ueno)
    #52734
lib,src:
  * remove --experimental-policy (Rafael Gonzaga)
    #52583
perf_hooks:
  * (SEMVER-MINOR) add `deliveryType` and `responseStatus` fields
    (Matthew Aitken) #51589
test_runner:
  * (SEMVER-MINOR) support test plans (Colin Ihrig)
    #52860
zlib:
  * (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung)
    #52692

PR-URL: #52971
targos added a commit that referenced this pull request May 15, 2024
2024-05-15, Version 22.2.0 (Current)
28b0a58 
Notable changes:

cli:
  * (SEMVER-MINOR) allow running wasm in limited vmem with
    --disable-wasm-trap-handler (Joyee Cheung)
    #52766
doc:
  * add pimterry to collaborators (Tim Perry)
    #52874
fs:
  * (SEMVER-MINOR) allow 'withFileTypes' to be used with globs
    (Aviv Keller) #52837
inspector:
  * (SEMVER-MINOR) introduce the `--inspect-wait` flag (Kohei Ueno)
    #52734
lib,src:
  * remove --experimental-policy (Rafael Gonzaga)
    #52583
perf_hooks:
  * (SEMVER-MINOR) add `deliveryType` and `responseStatus` fields
    (Matthew Aitken) #51589
test_runner:
  * (SEMVER-MINOR) support test plans (Colin Ihrig)
    #52860
zlib:
  * (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung)
    #52692

PR-URL: #52971
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
fs: allow 'withFileTypes' to be used with globs
b4eb464 
PR-URL: nodejs#52837
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
2024-05-15, Version 22.2.0 (Current)
eccd98f 
Notable changes:

cli:
  * (SEMVER-MINOR) allow running wasm in limited vmem with
    --disable-wasm-trap-handler (Joyee Cheung)
    nodejs#52766
doc:
  * add pimterry to collaborators (Tim Perry)
    nodejs#52874
fs:
  * (SEMVER-MINOR) allow 'withFileTypes' to be used with globs
    (Aviv Keller) nodejs#52837
inspector:
  * (SEMVER-MINOR) introduce the `--inspect-wait` flag (Kohei Ueno)
    nodejs#52734
lib,src:
  * remove --experimental-policy (Rafael Gonzaga)
    nodejs#52583
perf_hooks:
  * (SEMVER-MINOR) add `deliveryType` and `responseStatus` fields
    (Matthew Aitken) nodejs#51589
test_runner:
  * (SEMVER-MINOR) support test plans (Colin Ihrig)
    nodejs#52860
zlib:
  * (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung)
    nodejs#52692

PR-URL: nodejs#52971
henriquekirchheck mentioned this pull request Nov 15, 2024
Merged
8 tasks
Netail mentioned this pull request Nov 17, 2024
Closed
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aduh95 aduh95 left review comments
benjamingr benjamingr approved these changes
MoLow MoLow approved these changes
+2 more reviewers
targos targos left review comments
VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fs.glob add option to only include files (not directories) in the results entries

7 participants

Back | FazBrowse Home | New Git URL