deps: patch V8 to 12.4.254.16 - #52845
Conversation
Sorry, something went wrong.
|
Review requested:
|
Sorry, something went wrong.
|
@aduh95 Now I know why we didn't specify a commit message in the action settings. git node v8 already creates the commit (It's supposed to have a "Refs:" trailer). |
Sorry, something went wrong.
|
Maybe related: there's the following error in the output of the action: Error: spawn git ENOENT
at ChildProcess._handle.onexit (node:internal/child_process:286:19)
at onErrorNT (node:internal/child_process:484:16)
at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
errno: -2,
code: 'ENOENT',
syscall: 'spawn git',
path: 'git',
spawnargs: [ 'fetch', 'origin' ]
}
https://github.com/nodejs/node/actions/runs/8958849424/job/24603576667 |
Sorry, something went wrong.
|
That error was expected (I had reset the GH Actions cache). |
Sorry, something went wrong.
|
Here's a run on my fork with debug logs enabled: https://github.com/targos/node/actions/runs/9050008411/job/24864881790 Relevant: ##[debug]Changes to be committed: ##[debug] (use "git restore --staged <file>..." to unstage) ##[debug] modified: deps/v8/include/v8-version.h ##[debug] modified: deps/v8/infra/testing/builders.pyl ##[debug] modified: deps/v8/src/objects/js-objects.cc ##[debug] ##[debug]Local changes found So, I think there are two bugs:
|
Sorry, something went wrong.
|
With proper git setup: https://github.com/targos/node/actions/runs/9050110263/job/24865219130 For some reason, the action doesn't consider the new commit as a local change: ##[debug]DEFAULT_BRANCH: main ##[debug]$ git status ##[debug]On branch test-v8-patch ##[debug]Your branch is ahead of 'origin/test-v8-patch' by 1 commit. ##[debug] (use "git push" to publish your local commits) ##[debug] ##[debug]nothing to commit, working tree clean No local changes ##[debug]Node Action run completed with exit code 0 ##[debug]Set output result = unchanged ##[debug]Finishing: Run gr2m/create-or-update-pull-request-action@86ec1766034c81[73](https://github.com/targos/node/actions/runs/9050110263/job/24865219130#step:8:74)518f61d2075cc2a173fb8c97 |
Sorry, something went wrong.
|
Maybe we should just use git push and then use the GH API to create the PR if it doesn't exist. |
Sorry, something went wrong.
|
I'll try https://github.com/peter-evans/create-pull-request on my fork. It seems more maintained. |
Sorry, something went wrong.
This is an automated patch update of V8 to 12.4.254.16.