FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: update BUILDING.md previous versions links by targos · Pull Request #52852 · nodejs/node · GitHub

/ node Public

doc: update BUILDING.md previous versions links - #52852

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:update-previous
May 6, 2024
Merged

doc: update BUILDING.md previous versions links#52852
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:update-previous

Conversation

targos commented May 6, 2024

Copy link
Copy Markdown
Member

No description provided.

nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels May 6, 2024

UlisesGascon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

targos added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 6, 2024
benjamingr added the fast-track PRs that do not need to wait for 48 hours to land. label May 6, 2024

github-actions Bot commented May 6, 2024

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @benjamingr. Please 👍 to approve.

targos added the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2024
nodejs-github-bot merged commit b1b0233 into nodejs:main May 6, 2024

Copy link
Copy Markdown
Collaborator

Landed in b1b0233

targos deleted the update-previous branch May 6, 2024 12:31
targos added a commit that referenced this pull request May 8, 2024
PR-URL: #52852
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
PR-URL: nodejs#52852
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants


Back | FazBrowse Home | New Git URL