FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: fix doc update action by marco-ippolito · Pull Request #52890 · nodejs/node · GitHub

/ node Public

tools: fix doc update action - #52890

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:fix-update-tools
May 10, 2024
Merged

tools: fix doc update action#52890
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:fix-update-tools

Conversation

marco-ippolito commented May 8, 2024
edited
Loading

Copy link
Copy Markdown
Member

Trivial fix for #51192
Since the $NEW_VERSION is the concatenation of all updates it's always gonna fail the linting.
This is a low effort fix to have the action up and running
I tried to split the long string but I guess this simpler

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/security-wg

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 8, 2024
marco-ippolito added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 9, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 10, 2024
nodejs-github-bot merged commit 8e6a45b into nodejs:main May 10, 2024

Copy link
Copy Markdown
Collaborator

Landed in 8e6a45b

targos pushed a commit that referenced this pull request May 11, 2024
PR-URL: #52890
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
marco-ippolito added a commit that referenced this pull request Jun 17, 2024
PR-URL: #52890
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
PR-URL: nodejs#52890
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL