src: sync NODE_REPL_EXTERNAL_MODULE and kDisableNodeOptionsEnv - #52905
Merged
nodejs-github-bot merged 2 commits intoMay 23, 2024
Merged
src: sync NODE_REPL_EXTERNAL_MODULE and kDisableNodeOptionsEnv#52905nodejs-github-bot merged 2 commits into
nodejs-github-bot merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
RafaelGSS
force-pushed
the
disable-external-module
branch
from
fce6acc to
c031cfb
Compare
May 8, 2024 17:56
Copy link
Copy Markdown
Member
|
IMO if it's a breaking change it should be semver-minor or notable-change (But as a triage member, this isn't my decision, nor my place) |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/9008046172 |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Trott
approved these changes
May 14, 2024
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
No opinion from me on semver for this, but the code change LGTM.
Sorry, something went wrong.
Trott
reviewed
May 14, 2024
Comment thread
doc/api/cli.md
Outdated
Comment on lines
2783
to
2853
This comment was marked as resolved.
This comment was marked as resolved.
Copy link
Copy Markdown
Member
Actually, with a little more thought, I think this is semver patch, so I agree with @RafaelGSS. But I'll defer to Releasers who think otherwise or collaborators more knowledgable about how these features are used. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Whatever you say I'm happy with, I'm not a collaborator, so I really don't have much of an opinion (and experience) to really weigh in |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
RafaelGSS
force-pushed
the
disable-external-module
branch
from
ccfa477 to
0b16434
Compare
May 17, 2024 14:21
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/52905 ✔ Done loading data for nodejs/node/pull/52905 ----------------------------------- PR info ------------------------------------ Title src: sync NODE_REPL_EXTERNAL_MODULE and kDisableNodeOptionsEnv (#52905) Author Rafael Gonzaga (@RafaelGSS) Branch RafaelGSS:disable-external-module -> nodejs:main Labels c++, repl, author ready, needs-ci, commit-queue-squash Commits 2 - src: fix external module env and kDisableNodeOptionsEnv - fixup! src: fix external module env and kDisableNodeOptionsEnv Committers 1 - RafaelGSS PR-URL: https://github.com/nodejs/node/pull/52905 Fixes: https://github.com/nodejs/node/issues/51227 Reviewed-By: Rich Trott Reviewed-By: Joyee Cheung ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52905 Fixes: https://github.com/nodejs/node/issues/51227 Reviewed-By: Rich Trott Reviewed-By: Joyee Cheung -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - fixup! src: fix external module env and kDisableNodeOptionsEnv ℹ This PR was created on Wed, 08 May 2024 17:55:32 GMT ✔ Approvals: 2 ✔ - Rich Trott (@Trott): https://github.com/nodejs/node/pull/52905#pullrequestreview-2056494543 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/52905#pullrequestreview-2069699196 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-05-22T14:10:03Z: https://ci.nodejs.org/job/node-test-pull-request/59352/ - Querying data for job/node-test-pull-request/59352/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/9200620708 |
Sorry, something went wrong.
juanarbol
approved these changes
May 23, 2024
StefanStojanovic
added a commit
to JaneaSystems/node
that referenced
this pull request
May 27, 2024
2 PRs that landed independently caused this issue which makes every native suites run in CI fail on Windows. This is just a quick patch to unblock the CI. Refs: nodejs#52905 Refs: nodejs#52646
nodejs-github-bot
pushed a commit
that referenced
this pull request
May 27, 2024
2 PRs that landed independently caused this issue which makes every native suites run in CI fail on Windows. This is just a quick patch to unblock the CI. Refs: #52905 Refs: #52646 PR-URL: #53173 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 1, 2024
2 PRs that landed independently caused this issue which makes every native suites run in CI fail on Windows. This is just a quick patch to unblock the CI. Refs: #52905 Refs: #52646 PR-URL: #53173 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Merged
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#52905 Fixes: nodejs#51227 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
2 PRs that landed independently caused this issue which makes every native suites run in CI fail on Windows. This is just a quick patch to unblock the CI. Refs: nodejs#52905 Refs: nodejs#52646 PR-URL: nodejs#53173 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
2 PRs that landed independently caused this issue which makes every native suites run in CI fail on Windows. This is just a quick patch to unblock the CI. Refs: #52905 Refs: #52646 PR-URL: #53173 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #51227
Currently, I'm throwing kBootstrapError, but I'm almost sure this is not the appropriate error. In this case, should I create a new error?
Technically, this is a fix for kDisableNodeOptionsEnv, but it can be considered a breaking change for the ones relying on the current behavior (which is unlikely).