FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: update hljs with the latest styles by avivkeller · Pull Request #52911 · nodejs/node · GitHub

/ node Public

doc: update hljs with the latest styles - #52911

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
avivkeller:patch-19
May 13, 2024
ConversationCommits (2)ChecksFiles changed
Merged

doc: update hljs with the latest styles#52911
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
avivkeller:patch-19

Conversation

avivkeller commented May 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

This PR updates the hljs.css styling to use the latest styles (from the VSCode theme builtin to Highlight.js)

Dark:

Light:

nodejs-github-bot commented May 8, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/nodejs-website

nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 8, 2024

avivkeller commented May 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

@ovflowd I know you and that team are updating the docs, just want to make sure this wouldn't break anything

AugustinMauroy approved these changes May 9, 2024
View reviewed changes

AugustinMauroy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM !

avivkeller added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 9, 2024
aduh95 reviewed May 10, 2024
View reviewed changes

aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you add the missing semicolons? I don't really like this approach, I'd prefer much more using variables

Comment thread doc/api_assets/hljs.css Outdated
Comment thread doc/api_assets/hljs.css Outdated
avivkeller removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 10, 2024

avivkeller commented May 10, 2024

Copy link
Copy Markdown
Member Author

(removing author-ready, as @aduh95 left comments without approval)

I've made the requested changes in regards to the semicolons. I don't think variables will be effective here, as these stylings are from hljs and if they change in the future, it may be tedious to change each variable

ovflowd commented May 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Just a FYI we're moving away from Highlight.js very soon to Shiki, so I honestly would recommend you to avoid spending calories on any API Docs-related changes... in general, as all these styles will be discarded.

ovflowd added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 13, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 13, 2024
nodejs-github-bot merged commit 29884d1 into nodejs:main May 13, 2024

nodejs-github-bot commented May 13, 2024

Copy link
Copy Markdown
Collaborator

Landed in 29884d1

targos pushed a commit that referenced this pull request May 15, 2024
doc: update hljs with the latest styles
1f3634e 
PR-URL: #52911
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
targos mentioned this pull request May 15, 2024
Merged
marco-ippolito mentioned this pull request Jun 17, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
doc: update hljs with the latest styles
2f3f2ff 
PR-URL: #52911
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
doc: update hljs with the latest styles
eca348b 
PR-URL: nodejs#52911
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aduh95 aduh95 left review comments
MoLow MoLow approved these changes
ovflowd ovflowd approved these changes
+1 more reviewer
AugustinMauroy AugustinMauroy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL