path: fix toNamespacedPath on Windows - #52915
Merged
nodejs-github-bot merged 1 commit intoMay 13, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
benjamingr
approved these changes
May 9, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
avivkeller
approved these changes
May 9, 2024
avivkeller
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Tip
My review, while it shows my support, is not blocking/approving.
Sorry, something went wrong.
lpinca
approved these changes
May 9, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Is there anything else I can do to help this PR move forward? |
Sorry, something went wrong.
Merged
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#52915 Fixes: nodejs#30224 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an inconsistency in the implementation of win32.toNamespacedPath(). It appears that the forward slash / wasn't consistently being converted to a backslash \. This PR fixes this issue by returning resolvedPath in the toNamespacedPath().
I've also added a test case to make sure that there will not be any regression.
Fixes: #30224