test_runner: fix watch mode race condition - #52954
Merged
nodejs-github-bot merged 1 commit intoMay 14, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
benjamingr
approved these changes
May 12, 2024
benjamingr
reviewed
May 12, 2024
Comment thread
lib/internal/test_runner/runner.js
Outdated
MoLow
force-pushed
the
fix-test-runner-watch-mode
branch
from
b03a4ae to
6d33ed0
Compare
May 12, 2024 09:05
marco-ippolito
approved these changes
May 12, 2024
benjamingr
approved these changes
May 12, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
atlowChemi
approved these changes
May 12, 2024
anonrig
reviewed
May 12, 2024
Comment thread
lib/internal/test_runner/runner.js
Outdated
aduh95
reviewed
May 12, 2024
Comment thread
lib/internal/test_runner/runner.js
Outdated
MoLow
force-pushed
the
fix-test-runner-watch-mode
branch
from
6d33ed0 to
65586fd
Compare
May 13, 2024 06:43
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
benjamingr
approved these changes
May 13, 2024
targos
pushed a commit
that referenced
this pull request
May 15, 2024
PR-URL: #52954 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
PR-URL: #52954 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#52954 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #52936