src: convert all endian checks to constexpr - #52974
Merged
nodejs-github-bot merged 1 commit intoMay 25, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This is finally possible in C++20 without having to rely on compiler-defined macros, assuming none of our supported platforms are mixed-endian. Refs: nodejs#44411
anonrig
approved these changes
May 14, 2024
Comment thread
src/util.h
This comment was marked as spam.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
May 18, 2024
Merged
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
This is finally possible in C++20 without having to rely on compiler-defined macros, assuming none of our supported platforms are mixed-endian. Refs: nodejs#44411 PR-URL: nodejs#52974 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is finally possible in C++20 without having to rely on compiler-defined macros, assuming none of our supported platforms are mixed-endian.
Refs: #44411