FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

buffer: make compare/equals faster by tniessen · Pull Request #52993 · nodejs/node · GitHub

/ node Public

buffer: make compare/equals faster - #52993

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:buffer-fast-compare
May 16, 2024
ConversationCommits (1)ChecksFiles changed
Merged

buffer: make compare/equals faster#52993
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:buffer-fast-compare

Conversation

tniessen commented May 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

This patch adds a V8 fast API implementation for the buffer.compare binding, which is used both by Buffer.prototype.equals and Buffer.prototype.compare. In particular, it significantly improves the performance of comparing buffers for equality.

Local benchmark:

                                                                      confidence improvement accuracy (*)    (**)   (***)
buffers/buffer-compare-instance-method.js n=1000000 args=1 size=16           ***    225.73 %      ±16.81% ±22.62% ±29.94%
buffers/buffer-compare-instance-method.js n=1000000 args=1 size=16386        ***     15.57 %       ±1.32%  ±1.76%  ±2.29%
buffers/buffer-compare-instance-method.js n=1000000 args=1 size=4096         ***     61.44 %       ±6.15%  ±8.27% ±10.93%
buffers/buffer-compare-instance-method.js n=1000000 args=1 size=512          ***    181.97 %       ±7.02%  ±9.45% ±12.52%
buffers/buffer-compare-instance-method.js n=1000000 args=2 size=16                    1.82 %       ±3.08%  ±4.11%  ±5.39%
buffers/buffer-compare-instance-method.js n=1000000 args=2 size=16386                -0.02 %       ±1.38%  ±1.84%  ±2.39%
buffers/buffer-compare-instance-method.js n=1000000 args=2 size=4096           *     -2.30 %       ±2.21%  ±2.93%  ±3.82%
buffers/buffer-compare-instance-method.js n=1000000 args=2 size=512            *     -3.92 %       ±3.02%  ±4.02%  ±5.24%
buffers/buffer-compare-instance-method.js n=1000000 args=5 size=16                   -2.86 %       ±3.69%  ±4.93%  ±6.48%
buffers/buffer-compare-instance-method.js n=1000000 args=5 size=16386                -0.17 %       ±2.94%  ±3.93%  ±5.13%
buffers/buffer-compare-instance-method.js n=1000000 args=5 size=4096                 -0.62 %       ±2.00%  ±2.67%  ±3.47%
buffers/buffer-compare-instance-method.js n=1000000 args=5 size=512                  -1.16 %       ±3.34%  ±4.45%  ±5.79%
buffers/buffer-compare-offset.js n=1000000 size=16 method='offset'                   -0.75 %       ±3.85%  ±5.13%  ±6.68%
buffers/buffer-compare-offset.js n=1000000 size=16 method='slice'            ***     55.75 %       ±3.72%  ±4.97%  ±6.51%
buffers/buffer-compare-offset.js n=1000000 size=16386 method='offset'                 0.60 %       ±2.39%  ±3.19%  ±4.15%
buffers/buffer-compare-offset.js n=1000000 size=16386 method='slice'         ***     54.36 %       ±4.39%  ±5.85%  ±7.62%
buffers/buffer-compare-offset.js n=1000000 size=4096 method='offset'                 -0.17 %       ±2.52%  ±3.37%  ±4.41%
buffers/buffer-compare-offset.js n=1000000 size=4096 method='slice'          ***     53.48 %       ±4.26%  ±5.69%  ±7.44%
buffers/buffer-compare-offset.js n=1000000 size=512 method='offset'                   1.06 %       ±1.97%  ±2.63%  ±3.45%
buffers/buffer-compare-offset.js n=1000000 size=512 method='slice'           ***     49.36 %       ±5.02%  ±6.73%  ±8.88%
buffers/buffer-compare.js n=1000000 size=16                                  ***    136.22 %       ±6.78%  ±9.07% ±11.90%
buffers/buffer-compare.js n=1000000 size=16386                                 *      4.93 %       ±4.56%  ±6.10%  ±8.01%
buffers/buffer-compare.js n=1000000 size=4096                                ***     36.27 %       ±5.07%  ±6.79%  ±8.92%
buffers/buffer-compare.js n=1000000 size=512                                 ***    113.32 %       ±6.16%  ±8.27% ±10.92%
buffers/buffer-equals.js n=1000000 difflen='false' size=0                             0.39 %       ±2.76%  ±3.69%  ±4.84%
buffers/buffer-equals.js n=1000000 difflen='false' size=16386                ***     18.69 %       ±5.35%  ±7.20%  ±9.52%
buffers/buffer-equals.js n=1000000 difflen='false' size=512                  ***    141.31 %      ±10.23% ±13.77% ±18.22%
buffers/buffer-equals.js n=1000000 difflen='true' size=0                              0.23 %       ±2.81%  ±3.74%  ±4.87%
buffers/buffer-equals.js n=1000000 difflen='true' size=16386                 ***     -4.23 %       ±1.99%  ±2.66%  ±3.48%
buffers/buffer-equals.js n=1000000 difflen='true' size=512                           -1.28 %       ±4.89%  ±6.50%  ±8.47%

Be aware that when doing many comparisons the risk of a false-positive result increases.
In this case, there are 30 comparisons, you can thus expect the following amount of false-positive results:
  1.50 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.30 false positives, when considering a   1% risk acceptance (**, ***),
  0.03 false positives, when considering a 0.1% risk acceptance (***)

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1566/

buffer: make compare/equals faster
273d3e6 
This patch adds a V8 fast API implementation for the buffer.compare
binding, which is used both by Buffer.prototype.equals and
Buffer.prototype.compare. In particular, it significantly improves the
performance of comparing buffers for equality.
tniessen added buffer Issues and PRs related to the buffer subsystem. performance Issues and PRs related to the performance of Node.js. labels May 14, 2024
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 14, 2024
anonrig approved these changes May 14, 2024
View reviewed changes

anonrig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

legend

Trott added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels May 15, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 15, 2024
VoltrexKeyva approved these changes May 16, 2024
View reviewed changes

VoltrexKeyva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Amazing!

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label May 16, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 16, 2024

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented May 16, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59238/

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 16, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 16, 2024
nodejs-github-bot merged commit 075853e into nodejs:main May 16, 2024

nodejs-github-bot commented May 16, 2024

Copy link
Copy Markdown
Collaborator

Landed in 075853e

targos pushed a commit that referenced this pull request May 21, 2024
buffer: make compare/equals faster
d87f9af 
This patch adds a V8 fast API implementation for the buffer.compare
binding, which is used both by Buffer.prototype.equals and
Buffer.prototype.compare. In particular, it significantly improves the
performance of comparing buffers for equality.

PR-URL: #52993
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
RafaelGSS mentioned this pull request Jun 7, 2024
Merged

ronag commented Jun 14, 2024

Copy link
Copy Markdown
Member

@tniessen any chance we could do the same for indexOf?

tniessen added a commit to tniessen/node that referenced this pull request Jun 14, 2024
buffer: make indexOf(byte) faster
669be2d 
Add a V8 fast API implementation for indexOfNumber, which significantly
improves the performance of finding a single byte within a buffer.

Refs: nodejs#52993
tniessen mentioned this pull request Jun 14, 2024
Merged

tniessen commented Jun 14, 2024

Copy link
Copy Markdown
Member Author

@ronag Let's start with the simplest signature: #53455

nodejs-github-bot pushed a commit that referenced this pull request Jun 16, 2024
buffer: make indexOf(byte) faster
103623b 
Add a V8 fast API implementation for indexOfNumber, which significantly
improves the performance of finding a single byte within a buffer.

Refs: #52993
PR-URL: #53455
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos pushed a commit that referenced this pull request Jun 20, 2024
buffer: make indexOf(byte) faster
dfdc062 
Add a V8 fast API implementation for indexOfNumber, which significantly
improves the performance of finding a single byte within a buffer.

Refs: #52993
PR-URL: #53455
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
buffer: make compare/equals faster
6a0038b 
This patch adds a V8 fast API implementation for the buffer.compare
binding, which is used both by Buffer.prototype.equals and
Buffer.prototype.compare. In particular, it significantly improves the
performance of comparing buffers for equality.

PR-URL: nodejs#52993
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
buffer: make indexOf(byte) faster
953c7e9 
Add a V8 fast API implementation for indexOfNumber, which significantly
improves the performance of finding a single byte within a buffer.

Refs: nodejs#52993
PR-URL: nodejs#53455
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos pushed a commit that referenced this pull request Sep 21, 2024
buffer: make indexOf(byte) faster
3505782 
Add a V8 fast API implementation for indexOfNumber, which significantly
improves the performance of finding a single byte within a buffer.

Refs: #52993
PR-URL: #53455
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
anonrig anonrig approved these changes
+1 more reviewer
VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. performance Issues and PRs related to the performance of Node.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL