Revert "src: make sure pass the argv to worker threads" - #53021
Revert "src: make sure pass the argv to worker threads"#53021nicolo-ribaudo wants to merge 2 commits into
Conversation
Sorry, something went wrong.
|
What should I do about the cpp formatter failure? Edit the revert commit so that it doesn't only revert, but also fix formatting? Or add a new commit just to format? |
Sorry, something went wrong.
It should be possible to pass the `env` option to a worker even when the parent process is using a process-level flag, such as `--title` or a V8-specific flag. This test is currently failing in Node.js 22.2.0
This reverts commit aba4a00.
According to the error: CLANG_FORMAT_START=$(git merge-base HEAD main) make format-cpp I misread what you were asking. I'm not in any way the person to give advice on this, but I'd add a new commit for now, they can always be changed later |
Sorry, something went wrong.
I would add a fixup commit (git commit --fixup e05e0724): that simplifies the work of reviewers, and it will land as a single commit. Shouldn't the revert comes first, then the added test can be applied? Otherwise tests won't be passing on that first commit IIUC |
Sorry, something went wrong.
|
I have opened an PR and try to fix this. |
Sorry, something went wrong.
aba4a00 introduced a regression, making it impossible to use Worker's env option when the process is start with process-specific flags, such as --title or --expose_gc. See the new test case, in which all the three new Worker() calls fail.
aba4a00 was released yesterday in 22.2.0.
Commit 1:
Commit 2:
Fixes #53011, cc @theanarkh