FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: update repo docs to use 'CTC' by orangemocha · Pull Request #5304 · nodejs/node · GitHub

/ node Public

doc: update repo docs to use 'CTC' - #5304

Closed
orangemocha wants to merge 1 commit into
nodejs:masterfrom
JaneaSystems:orangemocha-docs
ConversationCommits (1)ChecksFiles changed
Closed

doc: update repo docs to use 'CTC'#5304
orangemocha wants to merge 1 commit into
nodejs:masterfrom
JaneaSystems:orangemocha-docs

Conversation

orangemocha commented Feb 18, 2016

Copy link
Copy Markdown
Contributor

No description provided.

orangemocha mentioned this pull request Feb 18, 2016
Open

cjihrig commented Feb 18, 2016

Copy link
Copy Markdown
Contributor

LGTM

Fishrock123 commented Feb 18, 2016

Copy link
Copy Markdown
Contributor

Rubber-stamp LGTM

thefourtheye reviewed Feb 18, 2016
View reviewed changes
Comment thread WORKING_GROUPS.md Outdated

thefourtheye Feb 18, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hmmm, if I understand correctly CTC is purely a technical body. So this should be TSC only I guess

Fishrock123 Feb 18, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hmmm right, more language needs to be updated. Technically it is the CTC that charters WG's to work on core, but this probably is still outdated.

orangemocha Feb 18, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You mean, it doesn't contemplate that WGs can be created at the TSC level too? How about if we renamed this section to "Node.js Core Working Groups"? Not sure if we need to mention here that there is a level above Core (TSC and TSC chartered WGs).

Fishrock123 Feb 18, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

"Node.js Core Working Groups"?

That could work

thefourtheye Feb 18, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We don't have non-core work groups right?

orangemocha Feb 18, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

There exist non-core Working Groups in the Node.js Foundation, which report to the TSC. There can also be other working groups that report to other Top Level Projects (e.g. Express or libuv).
I don't think it's strictly necessary for this doc to describe the whole hierarchy, and things that it doesn't have a governance over, though it could certainly be improved (perhaps with a link). Maybe room for another PR? :)

thefourtheye Feb 19, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sounds good. Thanks for clarifying :)

Fishrock123 added the doc Issues and PRs related to the documentations. label Feb 18, 2016

orangemocha commented Feb 18, 2016

Copy link
Copy Markdown
Contributor Author

Updated WORKING_GROUPS.md to refer to working groups as "Node.js Core Working Groups" in the title and first sentence of the doc.

orangemocha commented Feb 18, 2016

Copy link
Copy Markdown
Contributor Author

FYI @nodejs/ctc

jasnell commented Feb 19, 2016

Copy link
Copy Markdown
Member

Lgtm

orangemocha added a commit that referenced this pull request Feb 22, 2016
doc: update repo docs to use 'CTC'
18abb3c 
PR-URL: #5304
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

orangemocha commented Feb 22, 2016

Copy link
Copy Markdown
Contributor Author

Landed with 18abb3c. Thank you.

rvagg pushed a commit that referenced this pull request Feb 23, 2016
doc: update repo docs to use 'CTC'
a8862f5 
PR-URL: #5304
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 1, 2016
doc: update repo docs to use 'CTC'
d4d1446 
PR-URL: #5304
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 1, 2016
doc: update repo docs to use 'CTC'
e0b45e4 
PR-URL: #5304
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
doc: update repo docs to use 'CTC'
3d10afa 
PR-URL: #5304
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL