tools: update error message for Type Error - #53047
Merged
nodejs-github-bot merged 1 commit intoMay 25, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
ovflowd
approved these changes
May 19, 2024
ovflowd
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
atlowChemi
reviewed
May 20, 2024
Comment thread
tools/doc/type-parser.mjs
| `Unrecognized type: '${typeTextFull}'.\n` + | ||
| `Please, edit the type or update '${import.meta.url}'.`, | ||
| `Unrecognized type: '${typeTextFull}' in '${import.meta.url}'.\n` + | ||
| 'Valid types can be found at https://github.com/nodejs/node/blob/HEAD/tools/doc/type-parser.mjs', |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Maybe something like
Suggested change
| 'Valid types can be found at https://github.com/nodejs/node/blob/HEAD/tools/doc/type-parser.mjs', | |
| 'Valid types can be found, or amended, at https://github.com/nodejs/node/blob/HEAD/tools/doc/type-parser.mjs', |
Sorry, something went wrong.
benjamingr
approved these changes
May 20, 2024
juanarbol
approved these changes
May 20, 2024
juanarbol
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
jasnell
approved these changes
May 25, 2024
targos
pushed a commit
that referenced
this pull request
Jun 1, 2024
PR-URL: #53047 Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#53047 Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #53047 Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the error message for unrecognized types to include a link to the file that contains a list of valid types