test_runner: fix t.assert methods - #53049
Merged
nodejs-github-bot merged 4 commits intoMay 20, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The node:assert module contains several top level APIs that do not make sense to expose as methods on t.assert. Examples include AssertionError and CallTracker. This commit removes such APIs from t.assert. Refs: nodejs#52860
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
aduh95
reviewed
May 18, 2024
aduh95
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
If you want to write the code in a way that is not affected by prototype mutation, you'd need to move some things around
Sorry, something went wrong.
Comment thread
lib/internal/test_runner/test.js
Comment thread
lib/internal/test_runner/test.js
Outdated
benjamingr
approved these changes
May 18, 2024
atlowChemi
approved these changes
May 19, 2024
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Copy link
Copy Markdown
Contributor
Author
|
@aduh95 I have committed your suggestions directly. PTAL |
Sorry, something went wrong.
atlowChemi
approved these changes
May 19, 2024
MoLow
approved these changes
May 19, 2024
MoLow
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM, lint needs fixing
Sorry, something went wrong.
aduh95
reviewed
May 19, 2024
Comment thread
lib/internal/test_runner/test.js
Outdated
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
atlowChemi
approved these changes
May 20, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
approved these changes
May 20, 2024
targos
pushed a commit
that referenced
this pull request
May 21, 2024
The node:assert module contains several top level APIs that do not make sense to expose as methods on t.assert. Examples include AssertionError and CallTracker. This commit removes such APIs from t.assert. Refs: #52860 PR-URL: #53049 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
The node:assert module contains several top level APIs that do not make sense to expose as methods on t.assert. Examples include AssertionError and CallTracker. This commit removes such APIs from t.assert. Refs: nodejs#52860 PR-URL: nodejs#53049 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
The node:assert module contains several top level APIs that do not make sense to expose as methods on t.assert. Examples include AssertionError and CallTracker. This commit removes such APIs from t.assert. Refs: #52860 PR-URL: #53049 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The node:assert module contains several top level APIs that do not make sense to expose as methods on t.assert. Examples include AssertionError and CallTracker. This commit removes such APIs from t.assert.
This appears to have been lost in translation from cjihrig@89d9a7e to #52860.
Refs: #52860