src: simplify node modules traverse path - #53061
Merged
nodejs-github-bot merged 1 commit intoMay 21, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
anonrig
force-pushed
the
simplify-node-modules
branch
from
6c4dd78 to
168e137
Compare
May 19, 2024 19:45
anonrig
force-pushed
the
simplify-node-modules
branch
from
168e137 to
bd17978
Compare
May 19, 2024 19:55
anonrig
force-pushed
the
simplify-node-modules
branch
from
bd17978 to
c981546
Compare
May 20, 2024 00:26
lemire
approved these changes
May 20, 2024
lemire
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
ends_with and other C++20 features can probably simplify a lot of code. Good work.
Sorry, something went wrong.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
guybedford
approved these changes
May 20, 2024
Comment thread
src/node_modules.cc
Outdated
anonrig
force-pushed
the
simplify-node-modules
branch
from
c981546 to
1e3f1cc
Compare
May 21, 2024 00:15
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@lemire @guybedford can you review again? |
Sorry, something went wrong.
mcollina
approved these changes
May 21, 2024
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
lemire
approved these changes
May 21, 2024
lemire
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
tniessen
approved these changes
May 21, 2024
targos
pushed a commit
that referenced
this pull request
Jun 1, 2024
PR-URL: #53061 Reviewed-By: Daniel Lemire <daniel@lemire.me> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#53061 Reviewed-By: Daniel Lemire <daniel@lemire.me> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we now support C++20, we can simplify our node_modules.cc implementation with filesystem and several C++20 functions.
cc @nodejs/cpp-reviewers @GeoffreyBooth @aduh95