build: fix -j propagation to ninja - #53088
Merged
nodejs-github-bot merged 1 commit intoMay 25, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The expression containing MAKEFLAGS must be evaluated in a deferred context for the propagation to work in GNU make. Otherwise, regardless of the -j value passed to make, ninja will spawn a potentially greater number of parallel compilation tasks, which can quickly exhaust all available memory.
aduh95
approved these changes
May 23, 2024
aduh95
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Not sure how to test it, but the code logic LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Without this patch, ./configure --ninja followed by make -j4 will display ninja -C .... With this patch, make -j4 will instead show nina -C ... -j4. |
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
May 23, 2024
Copy link
Copy Markdown
Member
|
It might make sense to add a comment to prevent it from being reverted to the original version. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@lpinca I tend to agree, but I am not sure if it's worth going through CI again (which presumably doesn't even cover this branch). |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
It's your call. |
Sorry, something went wrong.
jasnell
approved these changes
May 25, 2024
targos
pushed a commit
that referenced
this pull request
Jun 1, 2024
The expression containing MAKEFLAGS must be evaluated in a deferred context for the propagation to work in GNU make. Otherwise, regardless of the -j value passed to make, ninja will spawn a potentially greater number of parallel compilation tasks, which can quickly exhaust all available memory. PR-URL: #53088 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
The expression containing MAKEFLAGS must be evaluated in a deferred context for the propagation to work in GNU make. Otherwise, regardless of the -j value passed to make, ninja will spawn a potentially greater number of parallel compilation tasks, which can quickly exhaust all available memory. PR-URL: nodejs#53088 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
The expression containing MAKEFLAGS must be evaluated in a deferred context for the propagation to work in GNU make. Otherwise, regardless of the -j value passed to make, ninja will spawn a potentially greater number of parallel compilation tasks, which can quickly exhaust all available memory. PR-URL: #53088 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The expression containing MAKEFLAGS must be evaluated in a deferred context for the propagation to work in GNU make. Otherwise, regardless of the -j value passed to make, ninja will spawn a potentially greater number of parallel compilation tasks, which can quickly exhaust all available memory.
cc @nodejs/build