| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
IIRC this is because it extracts from our API documentation the examples and compiles those as addon tests. Lines 279 to 323 in 4a54a80 ends up in test/addons/01_worker_support. |
Sorry, something went wrong.
|
I noticed that the test-ci-js target was already doing what I wanted – with the exception that it lacks the node binary as a prerequisite, and it didn't include --skip-tests flag like jstest has. |
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
That's deliberate -- test-ci-js (and corresponding test-ci-native) is used in node-test-binary-armv7l where the node binary is copied from node-cross-compile via our binary temp git repository (all part of node-test-commit-arm-fanned). |
Sorry, something went wrong.
Makes sense, that explains the comment just above the rule 👍 |
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
Commit Queue failed- Loading data for nodejs/node/pull/53105 ✔ Done loading data for nodejs/node/pull/53105 ----------------------------------- PR info ------------------------------------ Title build: add `--skip-tests` to `test-ci-js` target (#53105) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:jstest-only -> nodejs:main Labels build, needs-ci Commits 1 - build: add `--skip-tests` to `test-ci-js` target Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/53105 Reviewed-By: Richard Lau ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53105 Reviewed-By: Richard Lau -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 22 May 2024 17:05:28 GMT ✔ Approvals: 1 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/53105#pullrequestreview-2083248397 ✘ This PR needs to wait 6 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-05-29T08:53:17Z: https://ci.nodejs.org/job/node-test-pull-request/59508/ - Querying data for job/node-test-pull-request/59508/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/9284668581 |
Sorry, something went wrong.
PR-URL: #53105 Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: nodejs#53105 Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: #53105 Reviewed-By: Richard Lau <rlau@redhat.com>
| Back | FazBrowse Home | New Git URL |
A target that skips building the addons, which for some reason depend on tools/doc/node_modules to be available, which requires the internet.