[v20.x] vm: harden module type checks - #53109
Closed
legendecas wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
anonrig
approved these changes
May 22, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
marco-ippolito
approved these changes
May 23, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
marco-ippolito
force-pushed
the
backport-52162-to-20
branch
from
ed17172 to
f9c85f3
Compare
June 12, 2024 07:42
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
marco-ippolito
force-pushed
the
v20.x-staging
branch
2 times, most recently
from
d702971 to
044bcce
Compare
June 17, 2024 14:26
joyeecheung
reviewed
Jun 17, 2024
Comment thread
lib/internal/vm/module.js
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Isn't the freezing (from #49720) semver-major?
Sorry, something went wrong.
marco-ippolito
requested changes
Jun 17, 2024
marco-ippolito
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Blocking on #53109 (comment)
Sorry, something went wrong.
Check if the value returned from user linker function is a null-ish value. `validateInternalField` should be preferred when checking `this` argument to guard against null-ish `this`. Co-authored-by: Mike Ralphson <mike.ralphson@gmail.com> PR-URL: nodejs#52162 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
legendecas
force-pushed
the
backport-52162-to-20
branch
from
f9c85f3 to
5081f84
Compare
June 18, 2024 09:10
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
marco-ippolito
force-pushed
the
v20.x-staging
branch
from
a924e20 to
473fa73
Compare
June 19, 2024 09:12
marco-ippolito
force-pushed
the
v20.x-staging
branch
from
91dea21 to
44268c2
Compare
August 19, 2024 08:33
targos
approved these changes
Sep 21, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@marco-ippolito I believe the comment has been addressed. |
Sorry, something went wrong.
marco-ippolito
approved these changes
Sep 21, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Sep 26, 2024
Check if the value returned from user linker function is a null-ish value. `validateInternalField` should be preferred when checking `this` argument to guard against null-ish `this`. Co-authored-by: Mike Ralphson <mike.ralphson@gmail.com> PR-URL: #52162 Backport-PR-URL: #53109 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
targos
pushed a commit
that referenced
this pull request
Oct 2, 2024
Check if the value returned from user linker function is a null-ish value. `validateInternalField` should be preferred when checking `this` argument to guard against null-ish `this`. Co-authored-by: Mike Ralphson <mike.ralphson@gmail.com> PR-URL: #52162 Backport-PR-URL: #53109 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
targos
pushed a commit
that referenced
this pull request
Oct 2, 2024
Check if the value returned from user linker function is a null-ish value. `validateInternalField` should be preferred when checking `this` argument to guard against null-ish `this`. Co-authored-by: Mike Ralphson <mike.ralphson@gmail.com> PR-URL: #52162 Backport-PR-URL: #53109 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check if the value returned from user linker function is a null-ish value.
validateInternalField should be preferred when checking this argument to guard against null-ish this.
Co-authored-by: Mike Ralphson mike.ralphson@gmail.com
PR-URL: #52162
Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io