[v20x backport] test_runner backports - #53133
Closed
MoLow wants to merge 3 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The V8 WebAssembly trap handler setup for Windows was incorrectly nested within a POSIX conditional compilation block in src/node.cc. This caused the related functions to be effectively non-operational on Windows. The changes involve removing the Windows-specific code from the POSIX section and correctly placing it under the WIN32 check. This fix will ensure that the intended exception handling is active on Windows builds. Fixes: nodejs#52404 Refs: nodejs#35033 PR-URL: nodejs#52545 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This commit updates the test runner to suppress any output for filtered tests. Filtered tests no longer generate reporter events, and the unfiltered tests are renumbered in the output as though the filtered tests were not present. Skipped tests that are not filtered are still included in the output. This change is particularly useful when filtering a large number of tests, as the previously displayed skip output could be distracting. Fixes: nodejs#51383 PR-URL: nodejs#52221 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
PR-URL: nodejs#52296 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
marco-ippolito
approved these changes
May 24, 2024
Copy link
Copy Markdown
Member
|
#52221 is semver-major PRs that contain breaking changes and should be released in the next major version. ? |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
not sure why its marked as semver major since changes it output should be marked as such |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Im having some trouble resolving conflicts. here. I think it makes sense to postpone this change to v22, since it is hard to backport without #52221. |
Sorry, something went wrong.
marco-ippolito
force-pushed
the
v20.x-staging
branch
from
07c45ba to
e6d9fbe
Compare
May 27, 2024 11:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backports of #52221 and #52296
CC @nodejs/releasers