FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: fix FP16 bitcasts.h by StefanStojanovic · Pull Request #53134 · nodejs/node · GitHub

/ node Public

deps: fix FP16 bitcasts.h - #53134

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
JaneaSystems:mefi-fp16
May 28, 2024
Merged

deps: fix FP16 bitcasts.h#53134
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
JaneaSystems:mefi-fp16

Conversation

Copy link
Copy Markdown
Contributor

This is one of the upstream fixes needed to enable ClangCL on Windows. This has already landed in FP16 and was pulled to V8. We'll be using it as a floating patch until it is included in an official V8 release that we update to.

Refs: #52809

StefanStojanovic added the dependencies Pull requests that update a dependency file. label May 24, 2024
StefanStojanovic requested review from lemire and targos May 24, 2024 11:58

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels May 24, 2024
StefanStojanovic changed the title deps: FP16 fix from V8 deps: fix FP16 bitcasts.h May 24, 2024
anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label May 24, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 24, 2024

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label May 27, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 27, 2024

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

targos pushed a commit that referenced this pull request Sep 2, 2024
PR-URL: #53134
Refs: #52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 3, 2024
PR-URL: nodejs/node#53134
Refs: nodejs/node#52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 4, 2024
PR-URL: nodejs/node#53134
Refs: nodejs/node#52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 5, 2024
PR-URL: nodejs/node#53134
Refs: nodejs/node#52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 6, 2024
PR-URL: nodejs/node#53134
Refs: nodejs/node#52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 7, 2024
PR-URL: nodejs/node#53134
Refs: nodejs/node#52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 8, 2024
PR-URL: nodejs/node#53134
Refs: nodejs/node#52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 8, 2024
PR-URL: #53134
Refs: #52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 8, 2024
PR-URL: nodejs/node#53134
Refs: nodejs/node#52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 9, 2024
PR-URL: nodejs/node#53134
Refs: nodejs/node#52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 10, 2024
PR-URL: nodejs/node#53134
Refs: nodejs/node#52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 11, 2024
PR-URL: #53134
Refs: #52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 11, 2024
PR-URL: nodejs/node#53134
Refs: nodejs/node#52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 12, 2024
PR-URL: nodejs/node#53134
Refs: nodejs/node#52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 13, 2024
PR-URL: #53134
Refs: #52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 13, 2024
PR-URL: nodejs/node#53134
Refs: nodejs/node#52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 16, 2024
PR-URL: #53134
Refs: #52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 16, 2024
PR-URL: nodejs/node#53134
Refs: nodejs/node#52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 17, 2024
PR-URL: nodejs/node#53134
Refs: nodejs/node#52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Sep 17, 2024
PR-URL: nodejs#53134
Refs: nodejs#52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 18, 2024
PR-URL: nodejs/node#53134
Refs: nodejs/node#52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 19, 2024
PR-URL: #53134
Refs: #52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 19, 2024
PR-URL: nodejs/node#53134
Refs: nodejs/node#52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Sep 19, 2024
PR-URL: #53134
Refs: #52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos pushed a commit that referenced this pull request Sep 19, 2024
PR-URL: #53134
Refs: #52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 20, 2024
PR-URL: nodejs/node#53134
Refs: nodejs/node#52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 21, 2024
PR-URL: nodejs/node#53134
Refs: nodejs/node#52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 21, 2024
PR-URL: #53134
Refs: #52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL