meta: remove initializeCommand from devcontainer - #53137
Merged
nodejs-github-bot merged 1 commit intoMay 26, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
(Requesting review from @bnb - The original file author, I'd love some insight into the file and how it works) |
Sorry, something went wrong.
H4ad
approved these changes
May 24, 2024
H4ad
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Reading some examples at https://github.com/devcontainers/templates/, I don't think this command is something people use, it was probably added to develop.
Sorry, something went wrong.
anonrig
approved these changes
May 24, 2024
jasnell
approved these changes
May 25, 2024
Merged
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#53137 Fixes: nodejs#53129 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #53129
I'm no expert on devcontainer, so maybe an initializeCommand is needed, but the current setup (See #53129 for more info) destroys all other devcontainers.